Fixes the Regular Sequence dialog bug, refactors and improves its code #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes in regular sequence from @derekagorhom
Changed default options vaues
lloyddewit
requested changes
Feb 16, 2022
Co-authored-by: lloyddewit <[email protected]>
Co-authored-by: lloyddewit <[email protected]>
Co-authored-by: lloyddewit <[email protected]>
|
@Patowhiz just one outstanding comment above, what do you think? |
|
@Patowhiz the last mention of this is conflicts. I had earlier approved. |
|
@rdstern you may want to test and review this urgently before conflicts. |
rdstern
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
@Patowhiz that's a relief. At least one nasty bug less!
I hope @shadrackkibet or @lloyddewit can check and merge
|
@Patowhiz I have approved. Has @lloyddewit remaining point been addressed? |
yes, fully addressed thank you |
lloyddewit
approved these changes
Mar 31, 2022
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7199
Replaces PR #7217
Fixes the original bug explained in the issue and also the other issues raised in comments.
@derekagorhom this PR includes you changes in PR #7217. I decided to create a new PR because it will be easier for me to answer any questions raised about the changes made to other files.
@africanmathsinitiative/developers this is ready for review.
@rdstern @derekagorhom I looked into using the 'seq' function for both numeric and date options but I didn't do it in this PR, the changes made here surpassed my time estimates for such implementation. Perhaps @derekagorhom can have a look at it. I'm still not sure on how it can be correctly done and I could just create a new issue about it. Thanks.