-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an option to detect and report on empty columns into delete rows/columns dialog #7216
Added an option to detect and report on empty columns into delete rows/columns dialog #7216
Conversation
Updating master
Updating master
@rdstern should we remove empty columns in the original data frame or we should have it as a separate data frame? |
Hello @shadrackkibet, I have been researching on something here and still don't know how to implement it. |
Ann, leave this to me for now. I will alert you when to proceed. I think I understand what you need to complete the task from your explanation. Keep up the good work! Meanwhile, I suggest you move to another task. |
@anastasia-mbithe I have now made changes to this PR. You will notice I have added a
You can now pull the changes and test them from your end. Feel free to ask any questions or make changes at the dialog level, I didn't look into it much. Let me know if you find any bugs. |
@shadrackkibet, thank you so much for this, am following the code as well as testing the dialog. |
The default for the R function is both checked so I will go with that. @rdstern might have a different opinion. |
@rdstern you can look at this and also see if you are okay with the checkboxes. |
@anastasia-mbithe I can not check yet. When I load your branch it gives an error right at the start, namely: Then it doesn't let me load a data file. Keeps giving that error. Please tell me when I can check. The dialogue looks fine. |
updating branch
@rdstern The bug is fixed, check it now. |
@rdstern please check. I would like to close this one as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anastasia-mbithe @shadrackkibet great. Now seems to work fine.
This fixes #6883
Hello @rdstern and @shadrackkibet, I added the empty button at the top of the dialog, as well as the two checkboxes as suggested. I also set the functions and the dialog is working properly; I tested with a procurement dataset that had a lot of empty variables. Am working on adding a report in the output window, i.e.. xxx empty variables deleted or rows or both as suggested in the issue.