Added more options to rename multiple columns #7208

N-thony · 2022-02-08T07:34:00Z

Fixes (partially) #6877
This is still a work in progress. @shadrackkibet I have added the grid under the multiple options as suggested by @rdstern in the corresponding issue. At this stage, I would like your help on the backend side. I'm not sure about how the R code or proper package to use for renaming multiple variables through the grid.

implementing a delete option on the cells of reogrid

shadrackkibet · 2022-02-10T11:06:46Z

@N-thony thanks for the discussion. Leave this to me for now. I will alert you when the R code is ready.

N-thony · 2022-02-10T11:10:56Z

@N-thony thanks for the discussion. Leave this to me for now. I will alert you when the R code is ready.

@shadrackkibet sounds good. Thanks.

shadrackkibet · 2022-02-10T16:01:40Z

instat/dlgName.vb

+            If Not ucrReceiverColumns.IsEmpty() Then
+                ucrBase.OKEnabled(True)
+            Else
+                ucrBase.OKEnabled(False)
+            End If


The default is to rename all columns. Therefore if the receiver is empty we use the whole data frame. This means we do not need to disable OK if the multiple receiver is empty.

shadrackkibet · 2022-02-10T20:01:09Z

@N-thony I have now added the R code that will allow the renaming of multiple columns one by one via a grid. I have also added an option to edit variable labels.

There are three type options single, multiple and rename_with. This corresponds to each of the top radio buttons.
I also fixed a bug under rename with. The column metadata should now update correctly to reflect the new names.
You will notice in the function I added two arguments new_column_names_df and new_labels_df which must be data frames of dimension 2. new_column_names_df contains the new columns names and the rows(indexes) that changed. new_labels_df contains the new variable labels and the respective rows (indexes) that changed.

You need to construct these data frames from the grid and pass them into the R function. Below is an illustration of how this should look like from the dialog;

data_book$rename_column_in_data(data_name="efc", 
                                type="multiple",
                                new_column_names_df = data.frame(cols = c("c12HOUR","e16SEX","e42DEP"),
                                                                 index = c(1,3,5)),
                                new_labels_df = data.frame(labels = c("spouse, child,sibling etc","Independent, slightly dependent, moderately dependent"),
                                                           index = c(2,5)))

N-thony · 2022-02-11T06:28:22Z

@N-thony I have now added the R code that will allow the renaming of multiple columns one by one via a grid. I have also added an option to edit variable labels.

There are three type options single, multiple and rename_with. This corresponds to each of the top radio buttons.

I also fixed a bug under rename with. The column metadata should now update correctly to reflect the new names.

You will notice in the function I added two arguments new_column_names_df and new_labels_df which must be data frames of dimension 2. new_column_names_df contains the new columns names and the rows(indexes) that changed. new_labels_df contains the new variable labels and the respective rows (indexes) that changed.

You need to construct these data frames from the grid and pass them into the R function. Below is an illustration of how this should look like from the dialog;
data_book$rename_column_in_data(data_name="efc", 
                                type="multiple",
                                new_column_names_df = data.frame(cols = c("c12HOUR","e16SEX","e42DEP"),
                                                                 index = c(1,3,5)),
                                new_labels_df = data.frame(labels = c("spouse, child,sibling etc","Independent, slightly dependent, moderately dependent"),
                                                           index = c(2,5)))

@shadrackkibet thanks, I will go ahead and link it with the grid.

N-thony · 2022-02-11T07:46:06Z

@rdstern I have now linked the R code provided by Shadrack with the grid. I did some tests and seems fine. Could you test too? Thanks.

rdstern

@N-thony so far I have just looked at the multiple. Not yet the rename_with.
a) Looks fine on manual changes.
b) When I paste from Excel they appear to change, but it doesn't register.
c) When I press Ok and have made a change, but not clicked elsewhere, then the last change doesn't register.
d) When I click to include labels it goes blank and freezes. (And, once it is working please test copying the old names and pasting into the variable labels.

N-thony · 2022-02-11T20:22:58Z

@N-thony so far I have just looked at the multiple. Not yet the rename_with. a) Looks fine on manual changes. b) When I paste from Excel they appear to change, but it doesn't register. c) When I press Ok and have made a change, but not clicked elsewhere, then the last change doesn't register. d) When I click to include labels it goes blank and freezes. (And, once it is working please test copying the old names and pasting into the variable labels.

@rdstern thanks for your comment. During our discussion we agreed to get the multiple option working well before moving to the rename_with option. Thanks for reminding about the pasting feature on the grid. I made some change regarding your comments above. I didn't yet finish to make a proper test to check if it is stable, but you may wish to test it too at this stage.

rdstern

@N-thony that's progress!
a) Paste is working, but only for the first cell thaqt is pasted.
b) Adding labels is now sensible. I only checked pasting, and that seems the same as the names, so it just pastes the first label.

N-thony · 2022-02-14T10:24:34Z

@rdstern I'm still looking into this. Meanwhile, @shadrackkibet I found that with the functions parameters passing the columns and indexes is a bit tricky. Using the survey dataset, I have the selected the three first column Village, field and size then through my dialogue I renamed both the name and label of village which the index is 1. Then click Ok. All runs fine, when I go back I expected to see only 2 columns here field and size since the new village name is not in the defined filter then, I do rename field column in the grid then I found it's still rename now the new village name column since now in the grid the index of field is 1. I can demonstrate this if you have a minute for a quick call.

rdstern

@N-thony looks fine to me. I am approving, so it can be merged. The next item is the abbreviate function, which I hope will be easy to add?

shadrackkibet · 2022-03-10T05:02:01Z

@N-thony abbreviate can be another radio button. Implement as follows;

data_book$rename_column_in_data(data_name="survey", type="rename_with", .fn=abbreviate)

If a control (Nud/input) is needed for minlength(R default =4) or any other parameter can be added as follows;

data_book$rename_column_in_data(data_name="survey", type="rename_with", .fn=abbreviate, minlength = 4)

rdstern · 2022-03-10T05:17:17Z

@shadrackkibet great to have this and a really good "quick win" for R-Instat. Once that is added and merged, then I suggest that the last feature in renaming (which overlaps with all your select stuff, i.e. your select is the find, and then we add replace!) becomes far less urgent, and could wait till later in the year. Certainly until you have everything you need in the Select stuff. So, I can write that as a new issue. (Maybe we don't even need the find, but it just works on a defined select!

shadrackkibet · 2022-03-10T07:09:55Z

@shadrackkibet great to have this and a really good "quick win" for R-Instat. Once that is added and merged, then I suggest that the last feature in renaming (which overlaps with all your select stuff, i.e. your select is the find, and then we add replace!) becomes far less urgent, and could wait till later in the year. Certainly until you have everything you need in the Select stuff. So, I can write that as a new issue. (Maybe we don't even need the find, but it just works on a defined select!

This should be straightforward to implement. In a nutshell, this will simply have a receiver to take in a select object then we just rename those columns in the select object.

…unction and set it the controls to use those parameters

rdstern · 2022-03-10T08:40:15Z

Exactly!

N-thony · 2022-03-10T09:39:05Z

@N-thony abbreviate can be another radio button. Implement as follows;

data_book$rename_column_in_data(data_name="survey", type="rename_with", .fn=abbreviate)

If a control (Nud/input) is needed for minlength(R default =4) or any other parameter can be added as follows;

data_book$rename_column_in_data(data_name="survey", type="rename_with", .fn=abbreviate, minlength = 4)

@rdstern @shadrackkibet I have added this.

shadrackkibet · 2022-03-10T10:23:01Z

instat/dlgName.vb

+        dctRowsNewNameChanged.Clear()
+        dctRowsNewLabelChanged.Clear()
+
+        ucrNudAbbreviate.SetText(4)


If you have the control passing the parameter then the control will read from the R code.

This is resolved

shadrackkibet · 2022-03-10T10:25:46Z

instat/dlgName.vb

    Private clsDefaultRFunction As New RFunction
+    Private clsNewColNameDataframeFunction As New RFunction
+    Private clsNewLabelDataframeFunction As New RFunction
+    Private clsDummyFunction As New RFunction


Try using conditions. Then you wouldn't need a dummy function. Happy to discuss.

clsDummyFunction concerns ucrChkIncludeLabels, and it will be improved in the implementation of the ucrControl appropriate for this grid

shadrackkibet · 2022-03-10T10:29:04Z

instat/dlgName.vb

+    Private Function GetValuesAsVector(dctValues As Dictionary(Of Integer, String)) As String
+        Dim strValue As String = ""
+        Dim i As Integer
+        strValue = strValue & "c("
+        For Each iRow As Integer In dctValues.Keys
+            If i > 0 Then
+                strValue = strValue & ","
+            End If
+            strValue = strValue & Chr(34) & dctValues(iRow) & Chr(34)
+            i = i + 1
+        Next
+        strValue = strValue & ")"
+        Return strValue
+    End Function
+
+    Private Sub ValidateNamesFromDictionary(iColIndex As Integer)
+        If iColIndex = 1 Then
+            For Each value In dctRowsNewNameChanged.Values
+                If Not CheckNames(value, iColIndex) Then
+                    MsgBox("The column name must not be a numeric or contains space or french accent or be a boolean e.g TRUE, FALSE, T, F.")
+                    bCurrentCell = False
+                    Exit For


We need to be moving this kind of code into user control. I think we have this kind of code in climatic data entry. I suggest you add a TODO comment.

instat/dlgName.vb

…r ucrControl

rdstern

@N-thony I think the abbreviate works fine now. But your function has now (behind the scenes) changed the janitor function for clean names. I think it also applies the default width from the abbreviate function.
At least the result of the clean names, with snake works fine in version 0.7.4 and is now different in your current function. I was trying with the iris set.

rdstern

Great - this is now an excellent new feature. Hope @shadrackkibet or @lloyddewit can approve, so it can be merged

lloyddewit · 2022-03-15T11:04:01Z

@N-thony I think there are 3 open comments from @shadrackkibet that are still open. Please could you fix these (without setting to resolved) and then ask @shadrackkibet to check. If he's happy, then he can resolve these remaining comments and approve.

@shadrackkibet thanks for reviewing this PR, I don't think I need to review also, but if you'd like me to review, then let me know, thanks

N-thony · 2022-03-15T12:24:49Z

@N-thony I think there are 3 open comments from @shadrackkibet that are still open. Please could you fix these (without setting to resolved) and then ask @shadrackkibet to check. If he's happy, then he can resolve these remaining comments and approve.

@shadrackkibet thanks for reviewing this PR, I don't think I need to review also, but if you'd like me to review, then let me know, thanks

@lloyddewit I think the three comments were already solved.

lloyddewit · 2022-03-15T13:07:47Z

@lloyddewit I think the three comments were already solved.

@N-thony I looked at the code and couldn't see where the comments are solved. Maybe I'm missing something. For each comment, please could you explain where/how the comment is solved?
thanks

lloyddewit · 2022-03-15T15:43:23Z

@N-thony thank you for the update
@shadrackkibet if you think that all your comments have been resolved, then please could you approve?
Thanks

shadrackkibet

@rdstern please approve then we can merge.

shadrackkibet and others added 12 commits February 5, 2022 09:41

trial

01851b5

added a function for replacing cell values with NA

805270a

Partially_Fixes_issues_#7149

75cd8ad

implementing a delete option on the cells of reogrid

Partially fixes delete implementation

6013ab4

Fixes error in line 850 of the ucrDataView

59f1008

Revert "Testing pr"

2106d69

Added the controls under Multiple option

1539832

Added the grid

fd9c95a

Added the list of labels

a30ab62

Added the position

f86908d

Added the comment

3c5943e

Minor bug fixes when column selection is applied

6fd500f

adding an option to rename multiple columns via a grid

4852e1d

shadrackkibet requested changes Feb 10, 2022

View reviewed changes

Linked the R code with the grid

106acc2

N-thony added 2 commits February 11, 2022 12:23

Minor bug fix

2e71584

Minor code change

9e1c104

rdstern requested changes Feb 11, 2022

View reviewed changes

N-thony added 2 commits February 11, 2022 21:44

Minor code amendements

8b8e30c

Added the pasting feature

f8794ed

rdstern requested changes Feb 11, 2022

View reviewed changes

N-thony added 2 commits February 12, 2022 08:57

Made the grid to fill faster

a611877

Minor code improvement

63af070

rdstern previously approved these changes Mar 9, 2022

View reviewed changes

N-thony added 2 commits March 10, 2022 11:19

Added the abbreviate function and minlenght parameter to the R code f…

be74004

…unction and set it the controls to use those parameters

Minor code change

976f90b

N-thony dismissed rdstern’s stale review via 976f90b March 10, 2022 08:40

N-thony added 2 commits March 10, 2022 11:49

revert the R code

2a58025

Minor bug fixes

b628f99

shadrackkibet requested changes Mar 10, 2022

View reviewed changes

N-thony added 3 commits March 10, 2022 18:28

Resolved comments on R code default state and added comnent to sub fo…

fbfa66c

…r ucrControl

Minor code addition

c9da485

Fix bug

15ee7d3

rdstern requested changes Mar 10, 2022

View reviewed changes

fixed the developer error

cb4cdce

rdstern previously approved these changes Mar 10, 2022

View reviewed changes

Minor code change

cd05df2

N-thony dismissed rdstern’s stale review via cd05df2 March 15, 2022 13:16

minor code change

008bbba

shadrackkibet changed the title ~~Added options to the Prepare > Data Frame > Rename Column dialogue~~ Added more options to rename multiple columns Mar 15, 2022

shadrackkibet added the feature label Mar 15, 2022

shadrackkibet approved these changes Mar 15, 2022

View reviewed changes

rdstern approved these changes Mar 16, 2022

View reviewed changes

shadrackkibet merged commit bc99ca3 into IDEMSInternational:master Mar 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added more options to rename multiple columns #7208

Added more options to rename multiple columns #7208

N-thony commented Feb 8, 2022 •

edited

Loading

shadrackkibet commented Feb 10, 2022

N-thony commented Feb 10, 2022

shadrackkibet Feb 10, 2022

shadrackkibet commented Feb 10, 2022

N-thony commented Feb 11, 2022

N-thony commented Feb 11, 2022

rdstern left a comment

N-thony commented Feb 11, 2022

rdstern left a comment

N-thony commented Feb 14, 2022

rdstern left a comment

shadrackkibet commented Mar 10, 2022

rdstern commented Mar 10, 2022

shadrackkibet commented Mar 10, 2022

rdstern commented Mar 10, 2022

N-thony commented Mar 10, 2022

shadrackkibet Mar 10, 2022

N-thony Mar 15, 2022

shadrackkibet Mar 10, 2022

N-thony Mar 15, 2022

shadrackkibet Mar 10, 2022

rdstern left a comment

rdstern left a comment

lloyddewit commented Mar 15, 2022

N-thony commented Mar 15, 2022

lloyddewit commented Mar 15, 2022

lloyddewit commented Mar 15, 2022

shadrackkibet left a comment

Added more options to rename multiple columns #7208

Added more options to rename multiple columns #7208

Conversation

N-thony commented Feb 8, 2022 • edited Loading

shadrackkibet commented Feb 10, 2022

N-thony commented Feb 10, 2022

shadrackkibet Feb 10, 2022

Choose a reason for hiding this comment

shadrackkibet commented Feb 10, 2022

N-thony commented Feb 11, 2022

N-thony commented Feb 11, 2022

rdstern left a comment

Choose a reason for hiding this comment

N-thony commented Feb 11, 2022

rdstern left a comment

Choose a reason for hiding this comment

N-thony commented Feb 14, 2022

rdstern left a comment

Choose a reason for hiding this comment

shadrackkibet commented Mar 10, 2022

rdstern commented Mar 10, 2022

shadrackkibet commented Mar 10, 2022

rdstern commented Mar 10, 2022

N-thony commented Mar 10, 2022

shadrackkibet Mar 10, 2022

Choose a reason for hiding this comment

N-thony Mar 15, 2022

Choose a reason for hiding this comment

shadrackkibet Mar 10, 2022

Choose a reason for hiding this comment

N-thony Mar 15, 2022

Choose a reason for hiding this comment

shadrackkibet Mar 10, 2022

Choose a reason for hiding this comment

rdstern left a comment

Choose a reason for hiding this comment

rdstern left a comment

Choose a reason for hiding this comment

lloyddewit commented Mar 15, 2022

N-thony commented Mar 15, 2022

lloyddewit commented Mar 15, 2022

lloyddewit commented Mar 15, 2022

shadrackkibet left a comment

Choose a reason for hiding this comment

N-thony commented Feb 8, 2022 •

edited

Loading