Small corrections to Prepare> Dataframe> Insert columns/rows dialog #7140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… down and kept N/A as default in the pull down
lloyddewit
previously approved these changes
Jan 19, 2022
rdstern
requested changes
Jan 20, 2022
There was a problem hiding this comment.
Sorry @mmulahvictor I think there is a problem that may have been there before?
When you give NA your command puts quotes round it. So, what is delivered is a string containing the characters NA. That's not the same as NA without the quotes, which would give missing.
While there, could you look at what give for the 0 options. I wonder if you give "0"? Certainly the result is a characet variable. Would it be possible to give just 0 and then check it is a numeric variable?
|
@mmulahvictor what is the state of this PR? |
@shadrackkibet it seems to be working ok. |
lloyddewit
approved these changes
Feb 3, 2022
|
@rdstern Please could you test again? thanks |
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7075
@shadrackkibet can you look at this changes.
@africanmathsinitiative/developers This is ready for review