Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French layout review Aug3 #6661

Merged

Conversation

rachelkg
Copy link
Contributor

@rachelkg rachelkg commented Aug 4, 2021

In this pull request I have redone changes to dialogs that had conflicts and addressed comments about my previous pull request. I will be working on this again Tuesday the 10th, so please merge by then if possible.

Thanks,

Rachel

shadrackkibet
shadrackkibet previously approved these changes Aug 5, 2021
Copy link
Collaborator

@shadrackkibet shadrackkibet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lloyddewit let's also merge this soon to avoid conflicts.

@lloyddewit
Copy link
Contributor

@shadrackkibet , @rachelkg unfortunately there are now conflicts in this PR, probably because we just merged PR #6558 and PR #6580.
PR #6543 is also waiting to be merged, and could cause further merge conflicts with this PR. I suggest that we first merge PR #6543 and then resolve the conflicts in this PR (and then merge this PR asap).

@N-thony As discussed, please resolve the compilation errors in PR #6543 so that we can roll back the conflicts, test and merge.
Thanks

I used the following Git commands:
$ git merge-base pr/6661-french-layout-review-aug3 master
506bdbd

$ git checkout 506bdbd --  dlgOneVariableGraph.resx dlgOneVariableSummarise.resx dlgOneWayFrequencies.resx sdgDataOptions.resx sdgFiltersFromFactor.resx sdgOneVarGraph.resx sdgSummaries.resx ucrAxes.Designer.vb ucrAxes.resx ucrSaveGraph.resx
@lloyddewit
Copy link
Contributor

@rachelkg Sorry, I needed to remove some conflicting files, you'll have to make these updates again in a new PR. From this point on, the risk of merge conflicts should be significantly less.

I removed the conflicting files from this PR with the git commands below.

$ git merge-base pr/6661-french-layout-review-aug3 master
506bdbd

$ git checkout 506bdbd -- dlgOneVariableGraph.resx dlgOneVariableSummarise.resx dlgOneWayFrequencies.resx sdgDataOptions.resx sdgFiltersFromFactor.resx sdgOneVarGraph.resx sdgSummaries.resx ucrAxes.Designer.vb ucrAxes.resx ucrSaveGraph.resx

@lloyddewit
Copy link
Contributor

@rdstern @shadrackkibet Please could one of you approve and merge? thanks

@shadrackkibet shadrackkibet merged commit 5354bc0 into IDEMSInternational:master Aug 6, 2021
@shadrackkibet shadrackkibet added bug skip-releasenotes PRs that don't affect functionality and should not be included in the release notes and removed bug labels Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants