Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tool Bar button tool tip translation (e.g. into French) #6529

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Added Tool Bar button tool tip translation (e.g. into French) #6529

merged 1 commit into from
Jun 17, 2021

Conversation

lloyddewit
Copy link
Contributor

This PR translates tool tips on the tool bar buttons. It partially fixes issue #3721.

@rdstern Please could you test?
If the tool tip text already has a French translation, then this is shown. Else the translation is shown as 'fr...'.
If you would like changes to the French translations, then please document these in issue #6512. I already documented the incorrect tranlation of the 'Help' tool tip.
Please note that the 'View Last Graph' and 'Column Metadata' button tool tips don't currently translate (I think because they're a different button type). I'll fix this in a separate PR.
I will also update the English JSON file in another PR (so that the remaining tool tip text is translated).
Thanks

@shadrackkibet The changes are all in the database and TranslateWinForms library, so there probably isn't much you can review here.

@lloyddewit lloyddewit changed the title Added tool bar tool tips Added tool bar tool tip translation (e.g. into French) Jun 13, 2021
@lloyddewit lloyddewit changed the title Added tool bar tool tip translation (e.g. into French) Added Tool Bar button tool tip translation (e.g. into French) Jun 13, 2021
@lloyddewit
Copy link
Contributor Author

The tool tip text to translate was added to the English JSON file in PR #6533.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants