-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added translations for (sub)dialog tool tips #6513
Added translations for (sub)dialog tool tips #6513
Conversation
This looks good. I saw you solved your remaining issue of being able to add the translation to the calculation keyboard, which is where I started. Another example is ceiling, translated as plafond. The tooltip is In each case we want to translate the first part, but we don't want to translate the formulae. So I then looked at the column summaries. Here there isn't the fr and instead the translation is implemented - fine. I like it. Now the task is to use the tooltips more! |
@shadrackkibet please could you approve and merge? thanks |
@lloyddewit Translation (mechanism) is part of the labels to be used in PRs? I thought we only use it for issues. This is the first PR with such a label. |
@shadrackkibet yes, you are right! thanks for noticing, I corrected it |
Partially fixes issue #3721
Translates tool tips associated with (sub)dialog controls. I still need to investigate tool bar tool tips.
@rdstern Please could you test? thanks
Please note that this PR includes a test database that 'translates' tool tips into French by adding 'fr'. I will create a separate PR for the real French CrowdIn translations.
@shadrackkibet Almost all the changes are in the TranslateWinform Nuget package so there is not much to review in this PR. You'll get an opportunity to review the Nuget package code in the coming weeks.