Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translations for (sub)dialog tool tips #6513

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Added translations for (sub)dialog tool tips #6513

merged 1 commit into from
Jun 7, 2021

Conversation

lloyddewit
Copy link
Contributor

@lloyddewit lloyddewit commented Jun 6, 2021

Partially fixes issue #3721
Translates tool tips associated with (sub)dialog controls. I still need to investigate tool bar tool tips.
@rdstern Please could you test? thanks
Please note that this PR includes a test database that 'translates' tool tips into French by adding 'fr'. I will create a separate PR for the real French CrowdIn translations.

@shadrackkibet Almost all the changes are in the TranslateWinform Nuget package so there is not much to review in this PR. You'll get an opportunity to review the Nuget package code in the coming weeks.

@lloyddewit lloyddewit added the Translation (mechanism) For issues when text should be translated but is not (or other way around); code update needed label Jun 6, 2021
@rdstern
Copy link
Collaborator

rdstern commented Jun 7, 2021

This looks good. I saw you solved your remaining issue of being able to add the translation to the calculation keyboard, which is where I started.
This showed (possibly) a potential problem for those translations. The first is sqrt that is translated as racine. The tooltip is frsquare root. For example sqrt(3) = 3 ^ 0.5 = 1.732.

Another example is ceiling, translated as plafond. The tooltip is frInteger above the given value. For example ceiling(3.5)=4, ceiling-3.5 = -3

In each case we want to translate the first part, but we don't want to translate the formulae. So ceiling can be translated, but not ceiling( . Or perhap[s nothing when the sentence has an = sign.

I then looked at the column summaries. Here there isn't the fr and instead the translation is implemented - fine.

image

I like it. Now the task is to use the tooltips more!

@lloyddewit
Copy link
Contributor Author

lloyddewit commented Jun 7, 2021

@rdstern Thank you for the test. If you are happy with the mechanism, then please could you approve?

I think that all your comments above can be solved by the CrowdIn translations. So I moved these comments to issue #6512

@lloyddewit
Copy link
Contributor Author

@shadrackkibet please could you approve and merge? thanks

@shadrackkibet shadrackkibet merged commit f20451a into IDEMSInternational:master Jun 7, 2021
@shadrackkibet
Copy link
Collaborator

@lloyddewit Translation (mechanism) is part of the labels to be used in PRs? I thought we only use it for issues. This is the first PR with such a label.

@lloyddewit lloyddewit added feature and removed Translation (mechanism) For issues when text should be translated but is not (or other way around); code update needed labels Jun 8, 2021
@lloyddewit
Copy link
Contributor Author

@lloyddewit Translation (mechanism) is part of the labels to be used in PRs? I thought we only use it for issues. This is the first PR with such a label.

@shadrackkibet yes, you are right! thanks for noticing, I corrected it

@lloyddewit lloyddewit deleted the issue3721TranslateTooltipsDialogs branch June 13, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants