Added 'Lan' language toggle button for subdialogs #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
@antoine this is a good addition and looks fine. Over to @lloyddewit for the check of the code perhaps.
I did find some curious translations in passing, but they aren't for here! log in the 2-variable model is translated as journal (like the log of activities, rather than the log function.) So I checked in the calculator and it is fine there - log stays as log. However the next key is tan and that is translated as brun (colour tan!)
lloyddewit
approved these changes
Jun 4, 2021
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6490
This PR add the language toggle button to subdialogs.
@africanmathsinitiative/developers @rdstern this is ready for review. Thanks