Added option to compare by row in the Compare Columns dialog #6433
Conversation
|
@HawardKetoyoMsatsi Thank you for the PR. When you open a PR, please could you add more details about what has changed. Is this a bug fix or enhancement? Is it related to an specific GitHub issue? @N-thony Please could you peer review? Thanks |
@lloyddewit I'm happy to do it. |
|
@N-thony I have fixed the issue raised concerning unnecessary comments. |
|
@HawardKetoyoMsatsi in this PR does this dialog expand and shrink it's size based on the radio button checked? If do, then the only thing left is linking the receiver to the |
|
@HawardKetoyoMsatsi in regards to my comment above, ignore it. After looking at your code the receiver is already linked and working correctly. |
| ucrBase.clsRsyntax.SetBaseRFunction(clsIfElseCompareFunction) | ||
| Me.Size = New System.Drawing.Size(Me.Width, iDialogHeight) | ||
| ucrBase.Location = New Point(ucrBase.Location.X, iBaseMaxY) | ||
| ucrSaveLogical.Location = New Point(ucrSaveLogical.Location.X, iBaseMaxY / 1.07) |
There was a problem hiding this comment.
Could we just set the 'Y' location to its original value?
| ucrSaveLogical.Location = New Point(ucrSaveLogical.Location.X, iBaseMaxY / 1.07) | |
| ucrSaveLogical.Location = New Point(ucrSaveLogical.Location.X, iBaseMaxY) |
There was a problem hiding this comment.
@HawardKetoyoMsatsi You marked this as resolved but the code was not changed. Please could you clarify?
Co-authored-by: lloyddewit <[email protected]>
Co-authored-by: lloyddewit <[email protected]>
Co-authored-by: lloyddewit <[email protected]>
Co-authored-by: lloyddewit <[email protected]>
|
@rdstern please could you retest/approve? thanks |
|
@shadrackkibet I'm happy to merge, but if you'd like to review first, then please go ahead |
|
@lloyddewit looks good. |
dannyparsons
changed the title
|
@HawardKetoyoMsatsi A more descriptive title for the PR would be useful in future as these appear in the release notes. "Updated" is a bit too vague. |
@shadrackkibet @africanmathsinitiative/developers @rdstern This is ready for review.
This PR addresses issues suggested by @shadrackkibet in PR #6414 .