Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the Inventory Plot subdialog design and fixed the tab order #6219

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Improved the Inventory Plot subdialog design and fixed the tab order #6219

merged 3 commits into from
Feb 22, 2021

Conversation

lilyclements
Copy link
Contributor

@africanmathsinitiative/developers this is ready to review

  • Tidied up sdgInventory Plot design
  • Tab order

Before:
image

image

image

image

image

After:
image

image

image

image

image

rdstern
rdstern approved these changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Looks much neater.

@lloyddewit lloyddewit changed the title sdgInventoryPlot Design Changes Improved the nIventory Plot subdialog design and fixed the tab order Feb 22, 2021
@lloyddewit lloyddewit added the bug label Feb 22, 2021
@lloyddewit lloyddewit changed the title Improved the nIventory Plot subdialog design and fixed the tab order Improved the Inventory Plot subdialog design and fixed the tab order Feb 22, 2021
@lloyddewit lloyddewit merged commit 753e0cb into IDEMSInternational:master Feb 22, 2021
@dannyparsons dannyparsons added Climatic and removed bug labels Feb 23, 2021
@lilyclements lilyclements deleted the sdgInventoryDesign branch March 24, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloyddewit lloyddewit lloyddewit approved these changes

@rdstern rdstern rdstern approved these changes

Assignees
No one assigned
Labels
Climatic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilyclements @rdstern @lloyddewit @dannyparsons