-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix on try control giving unwanted warning in the output window #6218
Bug fix on try control giving unwanted warning in the output window #6218
Conversation
Update release-drafter.yml
@africanmathsinitiative/developers this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadrackkibet I am very happy to see this warning disapear :)
I tested with the calculator dialog:
- entered invalid calculation
- pressed try
- pressed '...' to view details
- pressed ctrl-enter to exit popup
Everything worked correctly
@rdstern please could you test? thanks |
no longer needed |
Thanks for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Another related annoying warning is when opening the design view of some dialogs. This is caused by visual studio running commands even in design mode and finding nulls due to absence of connection to R. This could be addressed in another PR. It's more or less 2 lines of code being placed in strayegic places to detect whether the environment is in design mode or running mode. |
@shadrackkibet Thanks for adding the |
@Patowhiz Thanks for the suggestion. I rarely work on the dialogs so I don't experience this annoyance. If you think that the fix is simple enough to be worthwhile you could raise an issue. |
@lloyddewit this is a fix to avoid a warning message in the output window when debugging. You might have noticed that there is a warning on the compilation as shown in the below screenshot.
Investigations show that this originates from a warning in
ucrTry
line 217.