Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix on try control giving unwanted warning in the output window #6218

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

shadrackkibet
Copy link
Collaborator

@lloyddewit this is a fix to avoid a warning message in the output window when debugging. You might have noticed that there is a warning on the compilation as shown in the below screenshot.
image

Investigations show that this originates from a warning in ucrTry line 217.
image

@shadrackkibet
Copy link
Collaborator Author

@africanmathsinitiative/developers this is ready for review.

Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadrackkibet I am very happy to see this warning disapear :)
I tested with the calculator dialog:

  • entered invalid calculation
  • pressed try
  • pressed '...' to view details
  • pressed ctrl-enter to exit popup

Everything worked correctly

@lloyddewit
Copy link
Contributor

@rdstern please could you test? thanks

@lloyddewit
Copy link
Contributor

@africanmathsinitiative/developers this is ready for review.

no longer needed

@shadrackkibet
Copy link
Collaborator Author

@shadrackkibet I am very happy to see this warning disapear :)
I tested with the calculator dialog:

  • entered invalid calculation
  • pressed try
  • pressed '...' to view details
  • pressed ctrl-enter to exit popup

Everything worked correctly

Thanks for testing.

@shadrackkibet
Copy link
Collaborator Author

@rdstern?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@Patowhiz
Copy link
Contributor

Patowhiz commented Feb 19, 2021

Another related annoying warning is when opening the design view of some dialogs. This is caused by visual studio running commands even in design mode and finding nulls due to absence of connection to R. This could be addressed in another PR. It's more or less 2 lines of code being placed in strayegic places to detect whether the environment is in design mode or running mode.

@shadrackkibet shadrackkibet changed the title Warning in the output window Bug fix on try control giving unwanted warning in the output window Feb 19, 2021
@lloyddewit lloyddewit added the skip-releasenotes PRs that don't affect functionality and should not be included in the release notes label Feb 22, 2021
@lloyddewit
Copy link
Contributor

lloyddewit commented Feb 22, 2021

@shadrackkibet Thanks for adding the bug label and changing the title. I added the skip-release-notes label because I didn't think this fix was relevant for users.

@lloyddewit lloyddewit merged commit 857518a into IDEMSInternational:master Feb 22, 2021
@lloyddewit
Copy link
Contributor

Another related annoying warning is when opening the design view of some dialogs. This is caused by visual studio running commands even in design mode and finding nulls due to absence of connection to R. This could be addressed in another PR. It's more or less 2 lines of code being placed in strayegic places to detect whether the environment is in design mode or running mode.

@Patowhiz Thanks for the suggestion. I rarely work on the dialogs so I don't experience this annoyance. If you think that the fix is simple enough to be worthwhile you could raise an issue.

@shadrackkibet shadrackkibet deleted the enterwarning branch February 22, 2021 12:22
@shadrackkibet shadrackkibet restored the enterwarning branch February 22, 2021 12:49
@shadrackkibet shadrackkibet deleted the enterwarning branch February 22, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants