-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added checkmarks to four toolbar dropdown menu options ('Log Window', 'Script Window', 'Column Metadata' and 'Data Frame Metadata') #6210
Conversation
@rdstern what do you think about these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work fine.
a) the ticks in the toolbar are right at the top of the box, could they be a bit lower, as they are in the View menu.
b) Less important, but if they were a bit narrower it might also be a minor improvement. That would leave a small space before the text.
@rdstern I didn't find an easy way to sort out the display of ticks. If this is really crucial then I can spend some more time. |
@rdstern does this look better? Seems it is not easy to reposition the ticks. I checked the view menu and the ticks appear at the top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadrackkibet the width of the box is much better now. I can live with the tick being so high so am approving. I like it more in the view menu, where it is sort of high, but clearly in the box.
And I do like the feature.
Fixes #6207 @africanmathsinitiative/developers this is ready for review.