Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkmarks to four toolbar dropdown menu options ('Log Window', 'Script Window', 'Column Metadata' and 'Data Frame Metadata') #6210

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

shadrackkibet
Copy link
Collaborator

Fixes #6207 @africanmathsinitiative/developers this is ready for review.

image
image

@shadrackkibet
Copy link
Collaborator Author

@rdstern what do you think about these changes?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work fine.
a) the ticks in the toolbar are right at the top of the box, could they be a bit lower, as they are in the View menu.
b) Less important, but if they were a bit narrower it might also be a minor improvement. That would leave a small space before the text.

@shadrackkibet
Copy link
Collaborator Author

This seems to work fine.
a) the ticks in the toolbar are right at the top of the box, could they be a bit lower, as they are in the View menu.
b) Less important, but if they were a bit narrower it might also be a minor improvement. That would leave a small space before the text.

@rdstern I didn't find an easy way to sort out the display of ticks. If this is really crucial then I can spend some more time.

@shadrackkibet
Copy link
Collaborator Author

@rdstern does this look better? Seems it is not easy to reposition the ticks. I checked the view menu and the ticks appear at the top.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadrackkibet the width of the box is much better now. I can live with the tick being so high so am approving. I like it more in the view menu, where it is sort of high, but clearly in the box.

And I do like the feature.

@shadrackkibet shadrackkibet changed the title Checks on the tool bar icons Checks on the tool bar icons - Log and Script window, Column and Data frame metadata Feb 19, 2021
@lloyddewit lloyddewit changed the title Checks on the tool bar icons - Log and Script window, Column and Data frame metadata Added checkmarks to 4 toolbar dropdown menu options ('Log Window', 'Script Window', 'Column metadata' and 'Data Frame Metadata') Feb 22, 2021
@lloyddewit lloyddewit changed the title Added checkmarks to 4 toolbar dropdown menu options ('Log Window', 'Script Window', 'Column metadata' and 'Data Frame Metadata') Added checkmarks to 4 toolbar dropdown menu options ('Log Window', 'Script Window', 'Column Metadata' and 'Data Frame Metadata') Feb 22, 2021
@lloyddewit lloyddewit changed the title Added checkmarks to 4 toolbar dropdown menu options ('Log Window', 'Script Window', 'Column Metadata' and 'Data Frame Metadata') Added checkmarks to four toolbar dropdown menu options ('Log Window', 'Script Window', 'Column Metadata' and 'Data Frame Metadata') Feb 22, 2021
@lloyddewit lloyddewit merged commit 6788526 into IDEMSInternational:master Feb 22, 2021
@shadrackkibet shadrackkibet deleted the layout branch February 22, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tool bar items - column and data frame metadata, log and script window
3 participants