-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving and position columns bug fixes and changes #6067
Saving and position columns bug fixes and changes #6067
Conversation
merge from main
merge from main
… added parameter to R code to allow existing columns to be moved when replaced, fixed bug in calculator where before parameter was reset on reopening, added strAdjacentColumn as parameter to assign to methods
@Patowhiz You've done quite a bit of work in this area, please could you peer review? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Tested it across multiple dialogs that use the ucrSave control. ucrSave
control will need to be modified to enable positioning of existing columns and take advantage of the new parameter added. Issue #6002 will also need to be reopened to reimplement the functionality requested.
Just a few questions to @dannyparsons.
@dannyparsons @lloyddewit, on a separate note, now that @dannyparsons has worked on the |
Thanks, done and addressed the comments. |
@lloyddewit this looks good to me. |
before
parameter, and therefore positioning a new column, was changed when reopening the dialogstrAdjacentColumn
as a parameter to assign to methods as this is now part of the saving options@africanmathsinitiative/developers This is ready for the review. 1. needs to be reviewed across dialogs that use the save control, please test carefully as this edits core parts of saving columns, and 2. only needs to be checked for the calculator dialog