dlgStringHandling #5848
dlgStringHandling #5848
Conversation
instat/dlgStringHandling.vb
Outdated
| @@ -289,7 +289,7 @@ Public Class dlgStringHandling | |||
| Me.Size = New Size(iFullWidth, Me.Height) | |||
| Else | |||
| grpRegex.Visible = False | |||
| Me.Size = New Size(iFullWidth / 1.57, Me.Height) | |||
| Me.Size = New Size(536, Me.Height) | |||
There was a problem hiding this comment.
I am concerned about this kind of change. Calculation of width and height by a factor e.g iFullWidth / 1.57 is meant to enable resizing of dialogs to adapt well in computers with different resolutions. I think we should stick with that rather than fixing height e.g 536.
There was a problem hiding this comment.
Good to know, that makes a lot of sense. I will fix that now - thanks!
|
Please add the previous and the current designer look. |
|
Before:
After: Note that it does extend if the regex box is visible, however, since a checkbox is disabled this currently will not be visible. |
|
The designer looks good to me now. However, I noted that the code could be refactored better on the linking bits which are done manually. Since the regex keyboard is not working at the moment I think we can do it once it is enabled. @rdstern @lloyddewit can you review now? |
There was a problem hiding this comment.
This now looks much neater and I am happy to approve. So, subject to @lloyddewit approval I suggest it can be merged. Two further comments:
- @shadrackkibet is much more fussy/picky than I am - and this is a compliment in this work. So I would be happy for him to be the main reviewer of these changes.
- I believe @lilyclements has an old draft guide (based on a Windows guide) on good practice in constructing dialogues. I would be delighted if this could be resurrected and some of the points from these types of changes could also be included?
|
@rdstern Please could you approve (using the GitHub approve mechanism)? then we can merge, thanks |
@africanmathsinitiative/developers this is ready for review
Fixes #5830
Changes