-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Trend keyboard and general changes to layout for the Hypothesis Tests dialog #5821
Conversation
Updating Master
@wyclife - this is looking good. |
@rdstern I have fixed the first 4 points above. @africanmathsinitiative/developers Could someone have a look at these changes. |
@Wycklife you have fixed the first 3 - here is the 4th d) Move the Try control slightly left, so it is aligned with the check boxes above (if aligned now, then move them all a bit left) and then it can also move upwards so it is next to the bottom row of the symbol keys. Move the other keys at the left so they all align and also so that the dialogue becomes less deep. Ignore the final point (e) above for now. I have discussed with @dannyparsons and will make a separate issue. |
@rdstern Done. Kindly check a gain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wycklife , that is a bit better but not quite right yet. We have just started adding @lilyclements back into the team and re-organising dialogues is one of her strengths. So I suggest it remains as your pull request, but she will do some edits of the layout. She is likely to have more ideas than those I gave you! Let's see.
@rdstern That's fine. |
…/master Merge from MC
@Wycklife would you mind updating this branch from the master copy? |
Updating Branch
…/master merge from mc
Design changes
@rdstern I have merged the changes made by @lilyclements into this branch. Could you please check if the designer is now okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to approve. I am commenting so @lloyddewit can check and hopefully approve.
@maxwellfundi I reviewed, it looks good and I''m happy to approve. Please merge, thanks |
@rdstern You already approved this. Please could you approve again so that we can merge? thanks |
1 similar comment
@rdstern You already approved this. Please could you approve again so that we can merge? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve again
Fixes #5816 and #5814
@africanmathsinitiative/developers This is ready for review