-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R packages #5645
R packages #5645
Conversation
@rdstern would you kindly look at this again |
ok Thanks |
Looked again and works very smoothly now - when it loads. It no longer asks for the mirror or the package. I queried before whether it could still give the list of packages available - which it did before, even when the name was ok. This time I would like it to give that list if there is an error, so we can see what is available? Is that possible? I would like it to do something different when it is successful compared to when it fails. Can it say anything about the loaded system in the output window? Whan you give the command in the script window that information is displayed in its own window, though not in the output. |
|
@@ -0,0 +1,101 @@ | |||
Imports instat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed
clsInstallPackage.SetRCommand("install.packages") | ||
clsInstallPackage.AddParameter("repos", Chr(34) & "https://cran.rstudio.com/" & Chr(34)) | ||
ucrBase.clsRsyntax.SetBaseRFunction(clsInstallPackage) | ||
End Sub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A space after each sub.
instat/dlgRPackages.vb
Outdated
Private Sub SetDefaults() | ||
clsInstallPackage = New RFunction | ||
clsInstallPackage.SetRCommand("install.packages") | ||
clsInstallPackage.AddParameter("repos", Chr(34) & "https://cran.rstudio.com/" & Chr(34)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter position?
instat/dlgRPackages.vb
Outdated
TestOkEnabled() | ||
End Sub | ||
|
||
Private Sub check() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capital "C"
cmdCheck.Enabled = False | ||
ucrInputMessage.Enabled = False | ||
End If | ||
End Sub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is possible to do this through our linking system.
SetRCodeForControls(bReset) | ||
bReset = False | ||
TestOkEnabled() | ||
End Sub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
@Ivanluv this needs a few changes to get it ready to merge. Could you get these few changes done soon? |
@rdstern Please review this. |
Tested this with @rdstern :-) |
@africanmathsinitiative/developers This is ready for review fixes #5601