-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to the calculator. #5626
Conversation
Updating master
Updating master
Updating Master
@rdstern I have fixed number 1-5. I need more clarification on number 6 and 7 kindly. |
Hi @Wycklife
|
@rdstern Thanks for the reply, I did item 4. but I can as well have a check on them. |
Here is an indication of the complete keyboard(s) with the items 6 and 7: |
@rdstern I have implemented the two keyboards. Could you kindly check whether the parameters passed by the keys are correct. I have changed the location of the base so as to allow full display of the string keyboard but I have realized it affects other keyboards i'e creating more space. I will ask @dannyparsons to help me solve the problem once he's done with the session. |
@rdstern I'm happy to make changes you'll suggest. |
@africanmathsinitiative/developers This is now ready for review. |
@Wycklife this is looking good. So just small suggestions. |
@rdstern I have made the changes. Kindly have a look. |
@rdstern this seems to have been fixed from your comments above. Cheers. |
Fixes #5623
This fixes the first 5 parts of the issue.
@africanmathsinitiative/developers This can be reviewed