Adding column chart option to dlgBar and Pie chart #5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating master
Updating master
|
@Patowhiz you can check this now. |
|
It looks good. I have checked that it seems to do all as before, and returns nicely to the dialogue on repeated occasions. I have not checked the code itself. Later a useful challenge for the graphics generally will be to be able to reproduce examples where the articles use the code. Here is an example, called dot plots and bar charts from Iowa University. |
|
@Patowhiz any final comments |
|
@Ogik99 @dannyparsons I will merge this before @Ivanluv 's and fix the conflict. @Ogik99 will be opening the new PR on recently discussed changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5464
@africanmathsinitiative/developers this is ready for review