Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding focus to the function in the Receiver Expression #5595

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

Ivanluv
Copy link
Contributor

@Ivanluv Ivanluv commented Nov 27, 2019

fixes #5576
@africanmathsinitiative/developers this is ready for review

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great - and amazing too. I checked with @volloholic who thought that the focus would need to be changed individually for each key.
That was because the keys are not user controls. But I get the idea here is that this was just a one-line change, because the receiver IS a user control and the change can be made here.

I suggest perhaps @maxwellfundi could do a final check - but for me this could be merged now. I checked using the calculator and various keyboards and also one of the modelling dialogues. I also checked with and without the arguments selected. It all seems ok. Excellent!

@maxwellfundi maxwellfundi merged commit 6190bf3 into IDEMSInternational:master Nov 29, 2019
@Ivanluv Ivanluv deleted the KeyBoardsFocus#5576 branch February 6, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keys on keyboards leave focus in wrong place?
3 participants