Start of Rains

[shadrackkibet]

@africanmathsinitiative/developers Fixes #4689. This is ready for review.

[Patowhiz]

Testing this

…

On Thu, Jul 26, 2018, 12:57 PM Shadrack Kibet ***@***.***> wrote: @africanmathsinitiative/developers <https://github.com/orgs/africanmathsinitiative/teams/developers> Fixes #4689 <#4689>. This is ready for review. ------------------------------ You can view, comment on, or merge this pull request online at: #4817 Commit Summary - Merge pull request #299 from africanmathsinitiative/master - Bug fix - updating start day properly in the calculations - Passing result_name as additional parameter pair File Changes - *M* instat/dlgStartofRains.vb <https://github.com/africanmathsinitiative/R-Instat/pull/4817/files#diff-0> (12) Patch Links: - https://github.com/africanmathsinitiative/R-Instat/pull/4817.patch - https://github.com/africanmathsinitiative/R-Instat/pull/4817.diff — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#4817>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUMqf0TZlIh0QLEZIRyJijQ459tY_Sh7ks5uKZJ8gaJpZM4VhhiR> .

[maxwellfundi]

@bethanclarke Can you help test this? @Patowhiz have you tested already?

[bethanclarke]

still need help with testing?

[shadrackkibet]

Yes please test this.

[bethanclarke]

This is working very well. However, as I have already mentioned to @shadrackkibet there is a problem with the data frame selector. He is working on this now

[shadrackkibet]

@dannyparsons could you please have a look at this dialog? There is a problem when all receivers are auto filled then you try to change the data frame on the selector it doesn't change.
However, when you empty one of the receivers one can now change the data frame.
On debugging it i have realized that in line 141 of ucrDataframe the data frame is changed back to the previous one. I am not sure how to fix this issue as the problem might be deeper in the code.

This is also the case for End of Rains dialog.

[shadrackkibet]

@bethanclarke issue with the data frame updating is now fixed. Please test this again.

[shadrackkibet]

@bethanclarke?

[shadrackkibet]

@dannyparsons this is now done. Please have a look at it.