Quality control for Rain #4595
Quality control for Rain #4595
Conversation
latest copy of master
|
Reviewing and testing this. |
| @@ -399,6 +399,7 @@ lower_quart_label="lower_quartile" | |||
| upper_quart_label="upper_quartile" | |||
| skewness_label="summary_skewness" | |||
| summary_skewness_mc_label="summary_skewness_mc" | |||
| summary_outlier_limit_label = "summary_outlier_limit" | |||
There was a problem hiding this comment.
I think there is a list of summary functions where this label should be added like the other summary functions?
all_summaries=c(sum_label, mode_label, count_label, count_missing_label, count_non_missing_label, sd_label, var_label, median_label, range_label, min_label, max_label, mean_label,quartile_label, lower_quart_label, upper_quart_label, skewness_label, kurtosis_label, summary_coef_var_label, summary_skewness_mc_label, summary_median_absolute_deviation_label, summary_Qn_label, summary_Sn_label, cor_label, cov_label,first_label, last_label, nth_label, n_distinct_label, proportion_label, count_calc_label)
| } | ||
|
|
||
| # kurtosis function | ||
| summary_kurtosis <- function(x, na.rm = FALSE, type = 2, ...) { |
There was a problem hiding this comment.
I see this function is a duplicate
There was a problem hiding this comment.
I will delete this duplicate once you're finished testing
| ucrChkOutlier.Enabled = False | ||
| ucrChkOutlier.Checked = False | ||
| ucrChkSkewedData.SetText("Skewed Data") | ||
| ucrChkSkewedData.Checked = False |
There was a problem hiding this comment.
I think you don't need this.
There was a problem hiding this comment.
I see you already have ucrChkSkewedData.SetRDefault("FALSE") and setvalues when checked and unchecked so this checkbox will be unchecked by default.
| @@ -59,7 +59,9 @@ Public Class dlgClimaticCheckDataRain | |||
| ucrChkDryMonth.SetText("Dry Month") | |||
| ucrChkDryMonth.Enabled = False | |||
| ucrChkOutlier.SetText("Outlier") | |||
| ucrChkOutlier.Enabled = False | |||
| ucrChkOutlier.Checked = False | |||
There was a problem hiding this comment.
Why do not need to specify whether its checked or not?
| @@ -501,6 +502,30 @@ summary_skewness_mc <- function(x, na.rm = FALSE, ...) { | |||
| return(robustbase::mc(x, na.rm = na.rm)) | |||
| } | |||
|
|
|||
| # skewness outlier limit function | |||
| summary_outlier_limit <- function(x, coef = 1.5, bupperlimit=TRUE, bskewedcalc=FALSE, skewnessweight = 4,na.rm = TRUE, ...){ | |||
There was a problem hiding this comment.
Just minor formatting here; bupperlimit=TRUE, bskewedcalc=FALSE to be bupperlimit = TRUE, bskewedcalc = FALSE and a space after every ,
|
This is working great, just a few small issues to sort out on the designer.
|
|
Thank you very much for testing this @shadrackkibet I will add the label, remove the duplicate skewness code and fix those issues with the designer soon |
|
I've merged this so @rdstern can test before release, but suggested changes can still be made. |
Added R-code for Outliers in Climatic Check Data Rain Dialog