Line geoms #4455

bethanclarke · 2018-03-15T12:10:39Z

Changed some aes parameters to not mandatory in abline, hline and vline

latest copy

- slope and intercept (geom_abline) - yintercept (geom_hline) - xintercept (geom_vline)

… to NULL

maxwellfundi · 2018-03-15T12:19:38Z

instat/ucrGeom.vb

-        clsgeom_abline.AddAesParameter("slope", strIncludedDataTypes:={"numeric"}, bIsMandatory:=True)
-        clsgeom_abline.AddAesParameter("intercept", strIncludedDataTypes:={"numeric"}, bIsMandatory:=True) '(required) intercept with the y axis of the line (the "b" in "y=ax+b") 
+        clsgeom_abline.AddAesParameter("slope", strIncludedDataTypes:={"numeric"})
+        clsgeom_abline.AddAesParameter("intercept", strIncludedDataTypes:={"numeric"}) '(required) intercept with the y axis of the line (the "b" in "y=ax+b") 


Why are these not mandatory anymore? This seems to be mandatory from this reference -http://sape.inf.usi.ch/quick-reference/ggplot2/geom_abline

bethanclarke · 2018-03-15T13:03:44Z

Hi Maxwell,

The slope and intercept parameters are mandatory but it is not mandatory to have these parameters set within the aes function.

We can have these parameters within aes function or within the ggplot or geom_abline function i.e. ``ggplot(data, aes(slope, intercept)) + geom_abline() - where we set variables to these parameters
or `ggplot(data, aes(), slope, intercept) + geom_abline()` - where we assign numeric values to these parameters

So if we have these as mandatory within in aes, then we cannot leave these blank on the dialog (layer dimensions tab) and then assign these parameters to a numeric value on the layer parameter tab

dannyparsons · 2018-03-15T17:55:55Z

This is possibly another type of "mandatory" that we should have, where a parameter is mandatory somewhere in the geom but not in a particular place.

… vline

maxwellfundi · 2018-03-27T11:09:27Z

@bethanclarke Is this ready for review yet?

bethanclarke · 2018-03-27T11:11:40Z

Hi @maxwellfundi, yes it's ready to review. Thanks

maxwellfundi · 2018-03-27T13:03:23Z

Great, @africanmathsinitiative/developers someone can review this now.

shadrackkibet · 2018-03-28T06:59:33Z

Reviewing and testing this now.

shadrackkibet · 2018-03-28T09:24:55Z

instat/ucrGeom.vb

@@ -1178,7 +1178,7 @@ Public Class ucrGeom

        'adding layer parameters
        'Geom_density layer parameters
-        clsgeom_violin.AddLayerParameter("draw_quantiles", "list", Chr(34) & "not(NULL)" & Chr(34), lstParameterStrings:={Chr(34) & "not(NULL)" & Chr(34), "0.25", "0.5", "0.75", "c(0.25, 0.5)", "c(0.25, 0.75)", "c(0.5,0.75)", "c(0.25,0.5,0.75)"}) 'If not(NULL) (default), draw horizontal lines at the given quantiles of the density estimate.
+        clsgeom_violin.AddLayerParameter("draw_quantiles", "list", Chr(34) & "NULL" & Chr(34), lstParameterStrings:={Chr(34) & "NULL" & Chr(34), "0.25", "0.5", "0.75", "c(0.25, 0.5)", "c(0.25, 0.75)", "c(0.5,0.75)", "c(0.25,0.5,0.75)"}) 'If not(NULL) (default), draw horizontal lines at the given quantiles of the density estimate - confusing instructions; it's say NULL is the default and when it not NULL and soemthing else then draw horizontal lines at the given quantiles of the density estimate


From R documentation the default is not(NULL) why did you change this? . I didn't understand your comment here perhaps you could clarify.

ok, i see the confusion in R documentation. Should this parameter value have quotes around?

Perhaps i am doing something wrong here.I loaded survey dataset, on line plot dialog i have Fert as X Variable and Field as single variable then on plot options layer parameters i select geom_violin and check draw_quantiles checkbox i see the default is NULL then return back to the main dialog and click ok i found a bug.

@shadrackkibet you are correct, NULL should not be in quotes in the code.

maxwellfundi · 2018-04-05T08:45:47Z

@bethanclarke whats the status of this?

bethanclarke · 2018-04-05T09:43:37Z

Hi Maxwell, I will look at this today. Having some trouble opening data in R-Instat so haven’t been able to test the dialog yet. Thanks Beth On 5 Apr 2018, at 09:45, Maxwell Fundi <[email protected]<mailto:[email protected]>> wrote: @bethanclarke<https://github.com/bethanclarke> whats the status of this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#4455 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APcKV4i37rPZsF5XlB9H6A4vbTE2P2v_ks5tldm8gaJpZM4SsCVX>.

shadrackkibet · 2018-04-05T09:57:09Z

@bethanclarke could this be same issue i am experiencing ?
When i try to load data from Instat collection i get this "error", which i don't understand why.

bethanclarke · 2018-04-05T10:00:25Z

Hi @shadrackkibet, I spoke to Danny and he said "You may have an older version of R which has this bug. Try updating to R 3.4.4 and see if that fixes it."

This fixed my problem however, I was having a different issue to you but it's worth updating R anyway to see if it fixes the issue you're having

dannyparsons · 2018-04-05T10:14:26Z

@shadrackkibet which dataset did you try to load?

shadrackkibet · 2018-04-05T11:25:03Z

@shadrackkibet which dataset did you try to load?

Just immediately i click Browse Import from Library dialog loads and then i got above error.Additionally, when i click open from File in File menu and Open icon, i got the same issue.

dannyparsons · 2018-04-05T11:32:28Z

It seems like the error is in displaying the File select dialog then. I'm not getting that on mine. Is anyone else getting this?

maxwellfundi · 2018-04-05T11:33:12Z

Am not getting this either.

shadrackkibet · 2018-04-05T15:08:26Z

@dannyparsons this is now ready for you to review.

bethanclarke added 3 commits March 12, 2018 10:48

Merge pull request #31 from africanmathsinitiative/master

7208967

latest copy

Changed the following parameters from mandatory to optional

b059508

- slope and intercept (geom_abline) - yintercept (geom_hline) - xintercept (geom_vline)

geom violin - draw_quantiles parameter default changed from not(NULL)…

e10f127

… to NULL

maxwellfundi reviewed Mar 15, 2018

View reviewed changes

changed numeric box from 0 decimal places to 2 for: abline, hline and…

51a10d4

… vline

shadrackkibet reviewed Mar 28, 2018

View reviewed changes

geom violin NULL issue

c555e05

shadrackkibet mentioned this pull request Apr 6, 2018

Climatic summaries #4484

Closed

dannyparsons merged commit 9da1527 into IDEMSInternational:master Apr 6, 2018

bethanclarke deleted the line-geoms branch June 7, 2018 10:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Line geoms #4455

Line geoms #4455

bethanclarke commented Mar 15, 2018

maxwellfundi Mar 15, 2018

bethanclarke commented Mar 15, 2018 •

edited

Loading

dannyparsons commented Mar 15, 2018

maxwellfundi commented Mar 27, 2018

bethanclarke commented Mar 27, 2018 •

edited

Loading

maxwellfundi commented Mar 27, 2018 •

edited

Loading

shadrackkibet commented Mar 28, 2018

shadrackkibet Mar 28, 2018

shadrackkibet Mar 28, 2018 •

edited

Loading

shadrackkibet Mar 28, 2018 •

edited

Loading

bethanclarke Apr 5, 2018

maxwellfundi commented Apr 5, 2018

bethanclarke commented Apr 5, 2018 via email

shadrackkibet commented Apr 5, 2018 •

edited

Loading

bethanclarke commented Apr 5, 2018

dannyparsons commented Apr 5, 2018

shadrackkibet commented Apr 5, 2018

dannyparsons commented Apr 5, 2018

maxwellfundi commented Apr 5, 2018

shadrackkibet commented Apr 5, 2018

Line geoms #4455

Line geoms #4455

Conversation

bethanclarke commented Mar 15, 2018

maxwellfundi Mar 15, 2018

Choose a reason for hiding this comment

bethanclarke commented Mar 15, 2018 • edited Loading

dannyparsons commented Mar 15, 2018

maxwellfundi commented Mar 27, 2018

bethanclarke commented Mar 27, 2018 • edited Loading

maxwellfundi commented Mar 27, 2018 • edited Loading

shadrackkibet commented Mar 28, 2018

shadrackkibet Mar 28, 2018

Choose a reason for hiding this comment

shadrackkibet Mar 28, 2018 • edited Loading

Choose a reason for hiding this comment

shadrackkibet Mar 28, 2018 • edited Loading

Choose a reason for hiding this comment

bethanclarke Apr 5, 2018

Choose a reason for hiding this comment

maxwellfundi commented Apr 5, 2018

bethanclarke commented Apr 5, 2018 via email

shadrackkibet commented Apr 5, 2018 • edited Loading

bethanclarke commented Apr 5, 2018

dannyparsons commented Apr 5, 2018

shadrackkibet commented Apr 5, 2018

dannyparsons commented Apr 5, 2018

maxwellfundi commented Apr 5, 2018

shadrackkibet commented Apr 5, 2018

bethanclarke commented Mar 15, 2018 •

edited

Loading

bethanclarke commented Mar 27, 2018 •

edited

Loading

maxwellfundi commented Mar 27, 2018 •

edited

Loading

shadrackkibet Mar 28, 2018 •

edited

Loading

shadrackkibet Mar 28, 2018 •

edited

Loading

shadrackkibet commented Apr 5, 2018 •

edited

Loading