-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added all the components for Duplicate dialog though it is still not fully functioning. #278
Conversation
Pulling upto date changes from the main branch.
Pulling upto date changes from the main branch.
… though still not fully working
Pulling changes from the main before making my commit
Added all the components for Duplicate dialog though it is still not fully functioning.
<trans-unit id="Box_Plot" translate="yes" xml:space="preserve"> | ||
<source>Box Plot</source> | ||
<target state="needs-review-translation" state-qualifier="tm-suggestion">Diagramme à surfaces</target> | ||
</trans-unit> | ||
<trans-unit id="Cancel" translate="yes" xml:space="preserve"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing boxplot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't remove the boxplot. Only asked Maxwell to create for me the dialogues that I wanted to work on then pulled the updated Main branch.
Also committed the multilingual resource files because I was adding tags to the controls.
Only worked on the duplicate dialogue. Sure I'll be more carefully when doing the commit.
From: David Sternmailto:[email protected]
Sent: 02/12/2015 12:57
To: africanmathsinitiative/Instatmailto:[email protected]
Cc: Polycarp Okockmailto:[email protected]
Subject: Re: [Instat] Added all the components for Duplicate dialog though it is still not fully functioning. (#278)
@@ -594,10 +594,6 @@
<trans-unit id="Box_Plot" translate="yes" xml:space="preserve">
<source>Box Plot</source>
<target state="needs-review-translation" state-qualifier="tm-suggestion">Diagramme à surfaces</target>
</trans-unit> <trans-unit id="Cancel" translate="yes" xml:space="preserve">
Why are you removing boxplot?
Reply to this email directly or view it on GitHub:
https://github.com/africanmathsinitiative/Instat/pull/278/files#r46395162
You need to be much more careful with what you are committing. |
Just completed the designer view for the dialog.