Correlations #1018
Correlations #1018
Conversation
Update main branch
Update main branch
Update main branch
|
Great! From: Steve Kogo [mailto:[email protected]] Implemented GGpairs plot in correlation dialogue You can view, comment on, or merge this pull request online at: Commit Summary
File Changes
Patch Links:
— |
| clsRGGPairsFunction.AddParameter("columns", dlgCorrelation.ucrReceiverMultipleColumns.GetVariableNames()) | ||
| clsRGraphics.SetOperatorParameter(True, clsRFunc:=clsRGGPairsFunction) | ||
| 'Calltype is not the right one but it works | ||
| frmMain.clsRLink.RunScript(clsRGraphics.GetScript(), 2) |
There was a problem hiding this comment.
Did this fix the error you were getting?
|
@dannyparsons I have fixed the ggpairs function in the sub-dialogue, @rdstern Could you suggest more plots to include in the correlation dialogue? |
|
@africanmathsinitiative/instat are required to install packages CCA and GGally in your Rstudio in for smooth running of your project |
|
@rdstern @dannyparsons I have implemented GGcorr in regression sub-dialogue though it is working with the defaults arguments at the moment. |
| End Sub | ||
|
|
||
| Private Sub ucrReceiverMultipleColumns_SelectionChanged() Handles ucrReceiverMultipleColumns.SelectionChanged | ||
| Public Sub ucrReceiverMultipleColumns_SelectionChanged() Handles ucrReceiverMultipleColumns.SelectionChanged | ||
| MultipleVariables = ucrSelectorDataFrameVarAddRemove.ucrAvailableDataFrames.strCurrDataFrame.ToString & "[," & ucrReceiverMultipleColumns.GetVariableNames() & "]" |
There was a problem hiding this comment.
Can this line be removed? I don't think it's needed anymore.
|
Hi Steve, this is looking great. I think Roger had the same idea about the correlation matrix |
|
|
||
| Private Sub ucrReceiverMultipleColumns_Load(sender As Object, e As EventArgs) Handles ucrReceiverMultipleColumns.Load | ||
|
|
||
| End Sub |
There was a problem hiding this comment.
Can you remove this? it's not doing anything.
|
@dannyparsons Kindly check the implementation of TestOKEnabled. |
|
|
||
| Private Sub TestOKEnabled() | ||
| If (rdoTwoColumns.Checked = True) Then | ||
| If ucrReceiverFirstColumn.IsEmpty() = False And ucrReceiverSecondColumn.IsEmpty() = False And (rdoPearson.Checked = True Or rdoKendall.Checked = True Or rdoSpearman.Checked = True) Then |
There was a problem hiding this comment.
This Ifstill needs an Else to set Ok Enabled to False. Otherwise, Ok is never disabled when rdoTwoColumns is checked.
|
@dannyparsons Kindly check the implementation of the proposed changes. |
|
Looks great. Can you explain to Mary how and why we changed the |
Implemented GGpairs plot in correlation dialogue