-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with enthalpy based states trying to use EoS before construciton #1505
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1505 +/- ##
==========================================
- Coverage 76.98% 76.98% -0.01%
==========================================
Files 382 382
Lines 61913 61911 -2
Branches 10130 10126 -4
==========================================
- Hits 47665 47660 -5
- Misses 11848 11852 +4
+ Partials 2400 2399 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pytest.fixture(scope="class") | ||
@pytest.fixture() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, why are we removing these scopes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They resulted in tests polluting other tests which resulted in unexpected failures (mainly the first check for defined state effect had flow on effects to other tests)
Fixes #1483
Summary/Motivation:
Issue #1483 identified that enthalpy-based state definitions in the modular property framework triggered calls to components constructed by the equation of state module before these had been instantiated. This PR defers the construction of the constraint relating total molar enthalpy to the phase molar enthalpies until after the EoS components have been instantiated.
Changes proposed in this PR:
enth_mol_eqn
in enthalpy based state definitions.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: