Fixing #1

ICanBoogie · Jan 19, 2015 · 343be11 · 343be11
1 parent 70c0b9b
commit 343be11
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/lib/Locale.php b/lib/Locale.php
@@ -85,6 +85,11 @@ class Locale implements \ArrayAccess
 	 */
 	public function __construct(Repository $repository, $code)
 	{
+		if (!$code)
+		{
+			throw new \InvalidArgumentException("Locale identifier cannot be empty.");
+		}
+
 		$this->repository = $repository;
 		$this->code = $code;
 	}

diff --git a/tests/LocaleCollectionTest.php b/tests/LocaleCollectionTest.php
@@ -49,4 +49,12 @@ public function test_existing_locale()
 		$this->assertInstanceOf('ICanBoogie\CLDR\Locale', self::$collection['fr']);
 		$this->assertInstanceOf('ICanBoogie\CLDR\Locale', self::$collection['en']);
 	}
+
+	/**
+	 * @expectedException \InvalidArgumentException
+	 */
+	public function test_empty_identifier()
+	{
+		self::$collection[''];
+	}
 }
diff --git a/tests/LocaleTest.php b/tests/LocaleTest.php
@@ -130,6 +130,14 @@ public function provide_test_localize()
 
 		];
 	}
+
+	/**
+	 * @expectedException \InvalidArgumentException
+	 */
+	public function test_empty_identifier()
+	{
+		new Locale(get_repository(), '');
+	}
 }
 
 namespace ICanBoogie\CLDR\LocaleTest;