Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab pipeline source up-to-dateness should take filters into account #5661

Merged
merged 1 commit into from
Mar 17, 2023
Merged

GitLab pipeline source up-to-dateness should take filters into account #5661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion components/collector/src/source_collectors/gitlab/source_up_to_dateness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ async def _landing_url(self, responses: SourceResponses) -> URL:
try:
for response in responses:
pipelines = await response.json()
urls.extend([(self._datetime(pipeline), pipeline["web_url"]) for pipeline in pipelines])
urls.extend([
(self._datetime(pipeline), pipeline["web_url"])
for pipeline in pipelines if self._include_pipeline(pipeline)
])
except StopAsyncIteration:
pass
return max(urls, default=(None, await super()._landing_url(responses)))[1]
Expand Down
1 change: 1 addition & 0 deletions docs/src/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ If your currently installed *Quality-time* version is v4.0.0 or older, please re
### Fixed

- The unit name of metrics in MS Teams notifications would not be rendered correctly. Fixes [#5347](https://github.com/ICTU/quality-time/issues/5347).
- GitLab pipeline source up-to-dateness should take filters into account. Fixes [#5181](https://github.com/ICTU/quality-time/issues/5181).

### Changed

Expand Down