Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkmarx metric URL should point to report #919

Closed
dicksnel opened this issue Jan 7, 2020 · 3 comments · Fixed by #933
Closed

Checkmarx metric URL should point to report #919

dicksnel opened this issue Jan 7, 2020 · 3 comments · Fixed by #933
Labels
Bug Something isn't working

Comments

@dicksnel
Copy link
Contributor

dicksnel commented Jan 7, 2020 •
edited
Loading

The Checkmarx CxSast URL in the Source column points to:

https://xxxx/CxWebClient/projectscans.aspx?id=123

This is an overview of all scans for the project. It should point directly to the last scan results:

https://xxxx/CxWebClient/ViewerMain.aspx?scanId=123456&ProjectID=123

Also, the URL should open in a new tab.

image
@fniessink
Copy link
Member

Opening links in a new tab is not recommended, see https://www.w3.org/TR/WCAG20-TECHS/G200.html.

@fniessink fniessink added the Bug Something isn't working label Jan 7, 2020
@dicksnel
Copy link
Contributor Author

dicksnel commented Jan 7, 2020

Maybe example 2 from the w3 link is applicable here?

@fniessink
Copy link
Member

Opening the link inplace doesn't "break or destroy the secure session" so I don't think so.

fniessink added a commit that referenced this issue Jan 13, 2020
@fniessink
Fix Checkmarx landing url. Fixes #919.
49a5f9a
@fniessink fniessink mentioned this issue Jan 13, 2020
Merged
fniessink added a commit that referenced this issue Jan 13, 2020
@fniessink
Fix Checkmarx landing url. Fixes #919. (#933)
d5f31c9 
* Fix Checkmarx landing url. Fixes #919.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Checkmarx landing url. Fixes #919. ICTU/quality-time
2 participants
@fniessink @dicksnel