Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an icon to the Source measurement entities tabs #8823

Closed
1 task
fniessink opened this issue May 31, 2024 · 1 comment · Fixed by #9239
Closed
1 task

Add an icon to the Source measurement entities tabs #8823

fniessink opened this issue May 31, 2024 · 1 comment · Fixed by #9239
Assignees
@fniessink
Labels
Usability

Comments

@fniessink
Copy link
Member

fniessink commented May 31, 2024 •
edited
Loading

  • Make the icons bigger (ideally as big as the images, but a little bit smaller is ok too).

Out of scope:

  • Grey scale
  • SVG version of logo's
  • Giving the icons a color.
@fniessink fniessink moved this from Inbox to Ready in Quality-time backlog Jun 14, 2024
@fniessink fniessink moved this from Ready to Development in progress in Quality-time backlog Jun 24, 2024
@fniessink fniessink moved this from Development in progress to Ready in Quality-time backlog Jun 24, 2024
@fniessink fniessink moved this from Ready to Development in progress in Quality-time backlog Jun 24, 2024
@fniessink fniessink self-assigned this Jun 24, 2024
@fniessink
Copy link
Member Author

fniessink commented Jun 26, 2024 •
edited
Loading

Semantic UI React seems to have a minimum size for images that is larger than for icons:

Image

We could make the icons a tad bigger, but the images would remain significantly larger.

Also, grey scale versions of the logo images would need to be created by hand. There is no option in Semantic UI to make images grey scale.

@fniessink fniessink moved this from Development in progress to Refinement agenda in Quality-time backlog Jun 26, 2024
fniessink added a commit that referenced this issue Jul 5, 2024
@fniessink
Add icons to tabs with measurement entities.
11e0d3e 
Closes #8823.
@fniessink fniessink moved this from Refinement agenda to Refinement in progress in Quality-time backlog Jul 11, 2024
@fniessink fniessink moved this from Refinement in progress to Development in progress in Quality-time backlog Jul 11, 2024
fniessink added a commit that referenced this issue Jul 15, 2024
@fniessink
Add icons to tabs with measurement entities.
b57b03b 
Closes #8823.
@fniessink fniessink mentioned this issue Jul 15, 2024
Merged
@fniessink fniessink linked a pull request Jul 15, 2024 that will close this issue
Add icons to tabs with measurement entities. #9239
Merged
@fniessink fniessink moved this from Development in progress to Reviewing in progress in Quality-time backlog Jul 15, 2024
fniessink added a commit that referenced this issue Jul 15, 2024
@fniessink
Add icons to tabs with measurement entities.
620fa98 
Closes #8823.
fniessink added a commit that referenced this issue Jul 16, 2024
@fniessink
Add icons to tabs with measurement entities.
ed1b9d8 
Closes #8823.
@github-project-automation github-project-automation bot moved this from Reviewing in progress to Merged in Quality-time backlog Jul 16, 2024
@fniessink fniessink moved this from Merged to Released in Quality-time backlog Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fniessink fniessink

Labels
Usability
Projects
Quality-time backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add icons to tabs with measurement entities. ICTU/quality-time
1 participant
@fniessink