Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the length of comments when metrics are collapsed. #8281

Closed
Tracked by #7762
Sebastiaan127001 opened this issue Mar 12, 2024 · 1 comment · Fixed by #9975
Closed
Tracked by #7762

Limit the length of comments when metrics are collapsed. #8281

Sebastiaan127001 opened this issue Mar 12, 2024 · 1 comment · Fixed by #9975
Assignees
@fniessink
Labels
Usability

Comments

@Sebastiaan127001
Copy link
Contributor

Sebastiaan127001 commented Mar 12, 2024 •
edited
Loading

When a metrics are collapsed, and technical debt comments have long texts, the metrics become unusably wide (row height). This forces the user to scroll a lot.

A metric comment should display no more than 1000 characters when the metric is collapsed (please test this thoroughly, when resizing your viewport to a narrower width the limit should be max 200 chars maybe?).

image
@Sebastiaan127001 Sebastiaan127001 mentioned this issue Mar 12, 2024
Open
20 tasks
@Sebastiaan127001 Sebastiaan127001 changed the title a metric comment should display no more than 1000 characters when the metric is collapsed (please test this thoroughly, when resizing your viewport to a narrower width the limit should be max 200 chars maybe?) limit comments Mar 12, 2024
@Sebastiaan127001 Sebastiaan127001 changed the title limit comments Limit the length of comments when metrics are collapsed. Mar 12, 2024
@fniessink fniessink moved this to To be refined in Quality-time backlog May 24, 2024
@fniessink
Copy link
Member

fniessink commented Sep 5, 2024 •
edited
Loading

This has been implemented for SourceEntityAttribute. Reuse this functionality for:

  • Measurement entity status rationale
  • Metric comments

@fniessink fniessink moved this from To be refined to Ready in Quality-time backlog Sep 5, 2024
@fniessink fniessink self-assigned this Oct 9, 2024
@fniessink fniessink moved this from Ready to Development in progress in Quality-time backlog Oct 9, 2024
fniessink added a commit that referenced this issue Oct 9, 2024
@fniessink
Cut off long text fields.
6a52691 
In metric tables, prevent the comment column from getting too wide and cut off comments that are longer than 250 characters.
In the measurement entity details, prevent the rationale column from getting too wide and cut off rationales that are longer than 250 characters.

Fixes #8281.
@fniessink fniessink mentioned this issue Oct 9, 2024
Merged
@fniessink fniessink linked a pull request Oct 9, 2024 that will close this issue
Cut off long text fields. #9975
Merged
fniessink added a commit that referenced this issue Oct 9, 2024
@fniessink
Cut off long text fields.
736eec3 
In metric tables, prevent the comment column from getting too wide and cut off comments that are longer than 250 characters.
In the measurement entity details, prevent the rationale column from getting too wide and cut off rationales that are longer than 250 characters.

Fixes #8281.
fniessink added a commit that referenced this issue Oct 11, 2024
@fniessink
Cut off long text fields.
975f0c3 
In metric tables, prevent the comment column from getting too wide and cut off comments that are longer than 250 characters.
In the measurement entity details, prevent the rationale column from getting too wide and cut off rationales that are longer than 250 characters.

Fixes #8281.
fniessink added a commit that referenced this issue Oct 14, 2024
@fniessink
Cut off long text fields.
d57e0ab 
In metric tables, prevent the comment column from getting too wide and cut off comments that are longer than 250 characters.
In the measurement entity details, prevent the rationale column from getting too wide and cut off rationales that are longer than 250 characters.

Fixes #8281.
fniessink added a commit that referenced this issue Oct 14, 2024
@fniessink
Cut off long text fields.
13ef924 
In metric tables, prevent the comment column from getting too wide and cut off comments that are longer than 250 characters.
In the measurement entity details, prevent the rationale column from getting too wide and cut off rationales that are longer than 250 characters.

Fixes #8281.
@github-project-automation github-project-automation bot moved this from Reviewing in progress to Merged in Quality-time backlog Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fniessink fniessink

Labels
Usability
Projects
Quality-time backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cut off long text fields. ICTU/quality-time
2 participants
@fniessink @Sebastiaan127001