Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The share feature adds a hashtag to the URL instead of replacing it #7761

Closed
fniessink opened this issue Dec 28, 2023 · 0 comments · Fixed by #7795
Closed

The share feature adds a hashtag to the URL instead of replacing it #7761

fniessink opened this issue Dec 28, 2023 · 0 comments · Fixed by #7795
Assignees
Labels
Bug Something isn't working

Comments

@fniessink
Copy link
Member

Describe the bug
The share feature adds a hashtag to the URL instead of replacing it. If the user navigates to a shared link and shares another link, it has two hashtags.

To Reproduce
Steps to reproduce the behaviour:

  1. Go the a Share tab
  2. Copy the link
  3. Open the link in another tab and go to a Share tab
  4. See that the link has two hashtags.

Expected behaviour
The code that adds the hashtag should strip existing hashtags first.

Additional context

Replace:

const metricUrl = `${window.location}#${metric_uuid}`

With something like:

const metricUrl = `${window.location.split("#")[0]}#${metric_uuid}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant