Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newest OWASP Dependency check version (9.x) #7655

Closed
denniebouman opened this issue Dec 12, 2023 · 1 comment · Fixed by #7656
Closed

Support newest OWASP Dependency check version (9.x) #7655

denniebouman opened this issue Dec 12, 2023 · 1 comment · Fixed by #7656
Assignees
Labels
Feature New, enhanced, or removed feature

Comments

@denniebouman
Copy link
Member

denniebouman commented Dec 12, 2023

Is your feature request related to a problem? Please describe.
After the upgrade to the latest OWASP Dependency check version (9.x), QT report errors, due to a changed xsd.

Error:

File "/home/collector/collector_utilities/functions.py", line 24, in parse_source_response_xml
    raise XMLRootElementError(allowed_root_tags, tree.tag)
collector_utilities.exceptions.XMLRootElementError: The XML root element should be one of "['{https://jeremylong.github.io/DependencyCheck/dependency-check.2.0.xsd}analysis', '{https://jeremylong.github.io/DependencyCheck/dependency-check.2.1.xsd}analysis', '{https://jeremylong.github.io/DependencyCheck/dependency-check.2.2.xsd}analysis', '{https://jeremylong.github.io/DependencyCheck/dependency-check.2.3.xsd}analysis', '{https://jeremylong.github.io/DependencyCheck/dependency-check.2.4.xsd}analysis', '{https://jeremylong.github.io/DependencyCheck/dependency-check.2.5.xsd}analysis', '{https://jeremylong.github.io/DependencyCheck/dependency-check.3.0.xsd}analysis', '{https://jeremylong.github.io/DependencyCheck/dependency-check.3.1.xsd}analysis']" but is "{https://jeremylong.github.io/DependencyCheck/dependency-check.4.0.xsd}analysis"

Describe the solution you'd like
Support version 4.0 of the xsd.
<analysis xmlns="https://jeremylong.github.io/DependencyCheck/dependency-check.4.0.xsd"><scanInfo><engineVersion>9.0.4</engineVersion>

@denniebouman denniebouman added the Feature New, enhanced, or removed feature label Dec 12, 2023
@fniessink fniessink self-assigned this Dec 12, 2023
@fniessink
Copy link
Member

The only diff is in an attribute Quality-time does not use.

diff ~/Downloads/dependency-check.3.1.xsd.xml ~/Downloads/dependency-check.4.0.xsd.xml

5,6c5,6
<            targetNamespace="https://jeremylong.github.io/DependencyCheck/dependency-check.3.1.xsd"
<            xmlns:dc="https://jeremylong.github.io/DependencyCheck/dependency-check.3.1.xsd">
---
>            targetNamespace="https://jeremylong.github.io/DependencyCheck/dependency-check.4.0.xsd"
>            xmlns:dc="https://jeremylong.github.io/DependencyCheck/dependency-check.4.0.xsd">
93c93
<             <xs:element name="confidentialImpact" type="xs:string" minOccurs="1" maxOccurs="1"/>
---
>             <xs:element name="confidentialityImpact" type="xs:string" minOccurs="1" maxOccurs="1"/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New, enhanced, or removed feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants