Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality-time stops contacting Jenkins due to Jenkins wrongly returning a 401 #652

Closed
fniessink opened this issue Oct 4, 2019 · 2 comments · Fixed by #654
Closed

Quality-time stops contacting Jenkins due to Jenkins wrongly returning a 401 #652

fniessink opened this issue Oct 4, 2019 · 2 comments · Fixed by #654
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@fniessink
Copy link
Member

fniessink commented Oct 4, 2019

The Jenkins LDAP-plugin sometimes fails to connect to the LDAP-server causing Jenkins to wrongly return a 401. Quality-time then assumes the user has entered a wrong password and stops contacting the source.

A work-around could be to only stop contacting sources when the credentials are new and not when we know they've been working in the past. And/or keep trying for a few times when we get a 401.

Considered but dismissed options for a work-around:

  • Work-around cannot be made specific for the Jenkins source, because Jenkins can also function as webserver for other sources such as JUnit, JaCoCo, and OJAudit reports.
  • Jira returns a 401 when submitting an invalid password, so simply distinguishing between 401 and 403 won't be a work-around either.

See https://issues.jenkins-ci.org/browse/JENKINS-54015.

@fniessink fniessink added the Bug Something isn't working label Oct 4, 2019
@fniessink fniessink added this to the v1.0 milestone Oct 4, 2019
@fniessink fniessink self-assigned this Oct 4, 2019
@fniessink
Copy link
Member Author

fniessink added a commit that referenced this issue Oct 4, 2019
@fniessink
Copy link
Member Author

We decided on removing the functionality to stop contacting sources after a 401 or 403. The risk that Quality-time will lock accounts after users enter a wrong password should be signficantly smaller due to #478.

fniessink added a commit that referenced this issue Oct 4, 2019
Don't stop contacting sources after receiving a 401 (Unauthorized) or 403 (Forbidden). Fixes #652.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant