Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store measurement values for all supported scales #637

Closed
fniessink opened this issue Oct 1, 2019 · 1 comment · Fixed by #642
Closed

Store measurement values for all supported scales #637

fniessink opened this issue Oct 1, 2019 · 1 comment · Fixed by #642
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@fniessink
Copy link
Member

At the moment, the measurement value stored is the value for the current scale. If the user changes the scale, the old measurement values (as displayed in the graphs) are wrong. Solution: store the values for each scale.

@fniessink fniessink added the Bug Something isn't working label Oct 1, 2019
@fniessink fniessink added this to the v1.0 milestone Oct 1, 2019
@fniessink fniessink self-assigned this Oct 1, 2019
@fniessink
Copy link
Member Author

@lhelwerd This changes the way measurements are stored. Previously, each measurement document contained one "value" attribute. After this bug fix is released, each measurement document will from then on (history will not be changed) contain a value per scale that the metric supports. E.g:

{"count": {"value": "10", "status": "target_met"}, "percentage": {"value": "2", "status": "target_not_met"}, ...}

fniessink added a commit that referenced this issue Oct 2, 2019
…t the graphs show correct information when the user changes the metric scale. Fixes #637.
fniessink added a commit that referenced this issue Oct 2, 2019
#642)

Store measurement values for each scale that a metric supports so that the graphs show correct information when the user changes the metric scale. Fixes #637.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant