-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When sorting by metric status, change sequence of colours #3184
Labels
Bug
Something isn't working
Comments
fniessink
changed the title
When sorting on priority, change sequence of colours
When sorting by metric status, change sequence of colours
Jan 7, 2022
In status: (m1, m2) => {
const attribute1 = status_order[get_metric_status(m1[1])];
const attribute2 = status_order[get_metric_status(m2[1])];
return attribute1.localeCompare(attribute2)
}, And const status_order = { "": "0", target_not_met: "1", debt_target_met: "2", near_target_met: "3", target_met: "4" }; This should become: const status_order = { "": "0", target_not_met: "1", near_target_met: "2", debt_target_met: "3", target_met: "4" }; |
fniessink
added
Bug
Something isn't working
and removed
Feature
New, enhanced, or removed feature
labels
Jan 7, 2022
fniessink
added a commit
that referenced
this issue
Jan 7, 2022
…d: 'unknown' (white), 'target not met' (red), 'near target met' (yellow), 'technical debt accepted' (grey), 'target met' (green). Fixes #3184.
fniessink
added a commit
that referenced
this issue
Jan 7, 2022
…d: 'unknown' (white), 'target not met' (red), 'near target met' (yellow), 'technical debt accepted' (grey), 'target met' (green). Fixes #3184.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed, the right order should be:
White
Red
Yellow/Amber
Grey
Green
I.e. reverse yellow and grey.
The text was updated successfully, but these errors were encountered: