Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sorting by metric status, change sequence of colours #3184

Closed
Sebastiaan127001 opened this issue Jan 6, 2022 · 1 comment · Fixed by #3195
Closed

When sorting by metric status, change sequence of colours #3184

Sebastiaan127001 opened this issue Jan 6, 2022 · 1 comment · Fixed by #3195
Assignees
Labels
Bug Something isn't working

Comments

@Sebastiaan127001
Copy link
Contributor

Sebastiaan127001 commented Jan 6, 2022

As discussed, the right order should be:
White
Red
Yellow/Amber
Grey
Green

I.e. reverse yellow and grey.

@Sebastiaan127001 Sebastiaan127001 added the Feature New, enhanced, or removed feature label Jan 6, 2022
@fniessink fniessink changed the title When sorting on priority, change sequence of colours When sorting by metric status, change sequence of colours Jan 7, 2022
@fniessink
Copy link
Member

fniessink commented Jan 7, 2022

In SubjectDetails.js, sorting by status is currently done as follows:

        status: (m1, m2) => {
            const attribute1 = status_order[get_metric_status(m1[1])];
            const attribute2 = status_order[get_metric_status(m2[1])];
            return attribute1.localeCompare(attribute2)
        },

And status_order is defined as:

    const status_order = { "": "0", target_not_met: "1", debt_target_met: "2", near_target_met: "3", target_met: "4" }; 

This should become:

    const status_order = { "": "0", target_not_met: "1",  near_target_met: "2", debt_target_met: "3", target_met: "4" }; 

@fniessink fniessink added Bug Something isn't working and removed Feature New, enhanced, or removed feature labels Jan 7, 2022
@fniessink fniessink self-assigned this Jan 7, 2022
fniessink added a commit that referenced this issue Jan 7, 2022
…d: 'unknown' (white), 'target not met' (red), 'near target met' (yellow), 'technical debt accepted' (grey), 'target met' (green). Fixes #3184.
fniessink added a commit that referenced this issue Jan 7, 2022
…d: 'unknown' (white), 'target not met' (red), 'near target met' (yellow), 'technical debt accepted' (grey), 'target met' (green). Fixes #3184.
fniessink added a commit that referenced this issue Jan 7, 2022
…d: 'unknown' (white), 'target not met' (red), 'near target met' (yellow), 'technical debt accepted' (grey), 'target met' (green). Fixes #3184. (#3195)
@fniessink fniessink moved this to Released in Quality-time backlog May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants