When time traveling, deleted reports are shown after their deletion date

[fniessink]

For example, a report deleted at December 1st, 2021 is visible when time traveling to December 2nd, 2021. When time traveling to the current date, the report is not shown.

The problem is that in latest_reports, the distinct report_uuids are retrieved while ignoring deleted reports. This means that if a report is deleted before the max_iso_timestamp, the previous undeleted report is retrieved.

def latest_reports(database: Database, data_model: dict, max_iso_timestamp: str = "") -> list[Report]:
    """Return the latest, undeleted, reports in the reports collection."""
    if max_iso_timestamp and max_iso_timestamp < iso_timestamp():
        report_filter = dict(deleted=DOES_NOT_EXIST, timestamp={"$lt": max_iso_timestamp})
        report_uuids = database.reports.distinct("report_uuid", report_filter)
        reports = []
        for report_uuid in report_uuids:
            report_filter["report_uuid"] = report_uuid
            report_dict = database.reports.find_one(report_filter, sort=TIMESTAMP_DESCENDING)
            report = Report(data_model, report_dict)
            reports.append(report)
    else:
        report_dicts = database.reports.find({"last": True, "deleted": DOES_NOT_EXIST})
        reports = [Report(data_model, report_dict) for report_dict in report_dicts]
    return reports

A simple solution is to retrieve all report_uuids, regardless of deletion status and then filter the deleted reports in the for loop:

def latest_reports(database: Database, data_model: dict, max_iso_timestamp: str = "") -> list[Report]:
    """Return the latest, undeleted, reports in the reports collection."""
    if max_iso_timestamp and max_iso_timestamp < iso_timestamp():
        report_filter = dict(timestamp={"$lt": max_iso_timestamp})
        report_uuids = database.reports.distinct("report_uuid", report_filter)
        reports = []
        for report_uuid in report_uuids:
            report_filter["report_uuid"] = report_uuid
            report_dict = database.reports.find_one(report_filter, sort=TIMESTAMP_DESCENDING)
            if report_dict.get("deleted"):
                continue
            report = Report(data_model, report_dict)
            reports.append(report)
    else:
        report_dicts = database.reports.find({"last": True, "deleted": DOES_NOT_EXIST})
        reports = [Report(data_model, report_dict) for report_dict in report_dicts]
    return reports