Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible Axe-core JSON processing for Source version metric type #2910

Closed
denniebouman opened this issue Nov 24, 2021 · 1 comment · Fixed by #2912
Closed

More flexible Axe-core JSON processing for Source version metric type #2910

denniebouman opened this issue Nov 24, 2021 · 1 comment · Fixed by #2912
Assignees
Labels
Feature New, enhanced, or removed feature

Comments

@denniebouman
Copy link
Member

Feature request, add more flexible Axe-core JSON processing for "Source version" metric type.
As the output of Axe-core is often aggregated by little custom scripts, be flexible in accepting different structures of the JSON format.

See also: #2657

@denniebouman denniebouman added the Feature New, enhanced, or removed feature label Nov 24, 2021
@fniessink
Copy link
Member

Parse error:

Traceback (most recent call last):
  File "/home/collector/base_collectors/source_collector.py", line 141, in __safely_parse_source_responses
    return await self._parse_source_responses(responses)
  File "/home/collector/base_collectors/source_collector.py", line 262, in _parse_source_responses
    versions = await self._parse_source_response_versions(responses)
  File "/home/collector/base_collectors/source_collector.py", line 267, in _parse_source_response_versions
    return await asyncio.gather(*[self._parse_source_response_version(response) for response in responses])
  File "/home/collector/source_collectors/axe_core/source_version.py", line 14, in _parse_source_response_version
    return Version((await response.json(content_type=None))["testEngine"]["version"])
TypeError: list indices must be integers or slices, not str

@fniessink fniessink self-assigned this Nov 25, 2021
fniessink added a commit that referenced this issue Nov 25, 2021
…rent ways people aggregate Axe-core output into one JSON file, for the 'source up-to-dateness' and 'version' metrics. Closes #2910.
fniessink added a commit that referenced this issue Nov 25, 2021
* More flexible parsing of Axe-core JSON files to account for the different ways people aggregate Axe-core output into one JSON file, for the 'source up-to-dateness' and 'version' metrics. Closes #2910.
@fniessink fniessink moved this to Released in Quality-time backlog May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New, enhanced, or removed feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants