Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A failed measurement will reset all false positive entities #1007

Closed
fniessink opened this issue Feb 11, 2020 · 0 comments · Fixed by #1008
Closed

A failed measurement will reset all false positive entities #1007

fniessink opened this issue Feb 11, 2020 · 0 comments · Fixed by #1008
Assignees
@fniessink
Labels
Bug Something isn't working

Comments

@fniessink
Copy link
Member

The failed measurement will result in a measurement document without any entities. The next scucessful measurement should ignore the failed measurement(s) when looking for entity status to copy and search for the most recent successfull measurement.
@fniessink fniessink added the Bug Something isn't working label Feb 11, 2020
fniessink added a commit that referenced this issue Feb 11, 2020
@fniessink
Changes made to violations, issues, warnings, etc., such as marking t…
93be61d 
…hem as false positive, would not carry over after a failed measurement, forcing the user to make the same changes again. Fixes #1007.
@fniessink fniessink mentioned this issue Feb 11, 2020
Merged
@fniessink fniessink self-assigned this Feb 11, 2020
fniessink added a commit that referenced this issue Feb 11, 2020
@fniessink
Changes made to violations, issues, warnings, etc., such as marking t…
8065c66 
…hem as false positive, would not carry over after a failed measurement, forcing the user to make the same changes again. Fixes #1007. (#1008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fniessink fniessink

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes made to violations, issues, warnings, etc., such as marking t… ICTU/quality-time
1 participant
@fniessink