GitLab pipeline source up-to-dateness should take filters into account (

#5661) Fixes #5181
ICTU · Mar 17, 2023 · 1a003a5 · 1a003a5
1 parent 57d0ce2
commit 1a003a5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/components/collector/src/source_collectors/gitlab/source_up_to_dateness.py b/components/collector/src/source_collectors/gitlab/source_up_to_dateness.py
@@ -89,7 +89,10 @@ async def _landing_url(self, responses: SourceResponses) -> URL:
         try:
             for response in responses:
                 pipelines = await response.json()
-                urls.extend([(self._datetime(pipeline), pipeline["web_url"]) for pipeline in pipelines])
+                urls.extend([
+                    (self._datetime(pipeline), pipeline["web_url"])
+                    for pipeline in pipelines if self._include_pipeline(pipeline)
+                ])
         except StopAsyncIteration:
             pass
         return max(urls, default=(None, await super()._landing_url(responses)))[1]

diff --git a/docs/src/changelog.md b/docs/src/changelog.md
@@ -17,6 +17,7 @@ If your currently installed *Quality-time* version is v4.0.0 or older, please re
 ### Fixed
 
 - The unit name of metrics in MS Teams notifications would not be rendered correctly. Fixes [#5347](https://github.com/ICTU/quality-time/issues/5347).
+- GitLab pipeline source up-to-dateness should take filters into account. Fixes [#5181](https://github.com/ICTU/quality-time/issues/5181).
 
 ### Changed