Source tarball for version 1.6 is broken

[jlaine]

Hi, I don't know what happened during the release process but the source tarball on PyPI does not match what is on github, and fails to build:

Running crc32c-1.6/setup.py -q bdist_egg --dist-dir /var/folders/nz/vv4_9tw56nv9k3tkvyszvwg80000gn/T/easy_install-c6x4oqdy/crc32c-1.6/egg-dist-tmp-tbmrrl9s
_crc32c.c:69:15: error: use of undeclared identifier 'crc32c_crc32_sw'; did you mean 'crc32c_crc32'?
        {"crc32_sw", crc32c_crc32_sw, METH_VARARGS, "Calculate crc32c using a software implementation."},
                     ^~~~~~~~~~~~~~~
                     crc32c_crc32
_crc32c.c:40:11: note: 'crc32c_crc32' declared here
PyObject* crc32c_crc32(PyObject *self, PyObject *args) {

See:
https://travis-ci.org/jlaine/aiortc/jobs/480762373

This is the offending diff:

--- github/_crc32c.c     2019-01-17 07:25:02.610620597 +0100
+++ pypi/_crc32c.c   2019-01-17 08:08:56.000000000 +0100
@@ -65,7 +65,8 @@
 
 
 static PyMethodDef CRC32CMethods[] = {
-       {"crc32",   crc32c_crc32,   METH_VARARGS, "Calculate crc32c using Intel SSE4.2 instruction."},
+       {"crc32",    crc32c_crc32,    METH_VARARGS, "Calculate crc32c using Intel SSE4.2 instruction."},
+       {"crc32_sw", crc32c_crc32_sw, METH_VARARGS, "Calculate crc32c using a software implementation."},
        {NULL, NULL, 0, NULL}        /* Sentinel */
 };
 

Could you please bin this release and push out an 1.7 version? (replacing files is not an option, it's going to be on pypi mirrors by now)

[rtobar]

Yes, sorry about that, I prepared the sdist locally and didn't realise I included these uncommitted changes. I'm preparing a 1.7 release now.

[jlaine]

We can close this now that 1.7 is out!

Note: allowing the code to compile on non-Intel platforms has gained us.. binary wheels for Raspberry Pi, yay!

https://www.piwheels.org/simple/crc32c/

[rtobar]

It's great to hear all is good now. I didn't know about piwheels, thanks for sharing that!