feature: start python NLP workers in embedded mode #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
force-pushed
the
feature/start-python-workers
branch
from
797048f
to
a5736d0
Compare
ClemDoum
force-pushed
the
feature/start-python-workers
branch
from
a5736d0
to
17ca462
Compare
ClemDoum
force-pushed
the
feature/start-python-workers
branch
from
17ca462
to
db6f51e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Following #1611 and to address #1452
This PR adds the ability to start worker pool of NLP Python workers when in
EMBEDDEDmode withAMQPsupport/bus type.TODO
Changes
datashare-appAdded
ExecutableExtensionHelperin charge of executing DS executable extension (non JAR)ProcessHandlerto cleanly handle external processes (dump pids, find running process of some type, kill process etc)Changed
WebAppto spawn NLP workers when inEMBEDDEDmode withAMQP, if such process are already running the application will ask the user to clean the phantom process (could be otherwise)