Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create dynamic ES name field #1173

Closed
mvanzalu opened this issue Aug 31, 2023 · 2 comments
Closed

feat: create dynamic ES name field #1173

mvanzalu opened this issue Aug 31, 2023 · 2 comments
Assignees
@mvanzalu
Labels
back

Comments

@mvanzalu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Related to the sort by filename issue, We want to create a new ElasticSearch field to store the filename (resourcename for docs, title for emails, subject for tweets, etc...) in lowercase in order to perform case insensitive sort.
@mvanzalu mvanzalu added the back label Aug 31, 2023
@mvanzalu mvanzalu self-assigned this Aug 31, 2023
@pirhoo pirhoo changed the title feat: create dynamic ES filename field feat: create dynamic ES name field Aug 31, 2023
@pirhoo
Copy link
Member

pirhoo commented Aug 31, 2023 •
edited
Loading

I would suggest we create two fields:

  • title based on resourcename for docs, subject for emails, etc...
  • titleNorm a sanitized version of name (lowercase + no accentuated characters)

@mvanzalu
Copy link
Contributor Author

We would probably add those 2 fields in this method

mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: adds title titleNorm in ES document fields #1173
700dba3
@mvanzalu mvanzalu mentioned this issue Sep 1, 2023
Merged
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: check if subject and title are empty #1173
9303f1d
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: use java Normalizer for titleNorm #1173
09ae7af
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: adds title titleNorm in ES document fields #1173
352e97f
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: check if subject and title are empty #1173
a72f855
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: use java Normalizer for titleNorm #1173
571bccf
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
feat: adds Title and Title Normalized in Document details ICIJ/datash…
dc3ffc9 
…are#1173
@mvanzalu mvanzalu mentioned this issue Sep 1, 2023
Merged
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
feat: remove title norm form document tab details ICIJ/datashare#1173
8e0cd15
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
feat: adds Title and Title Normalized in Document details ICIJ/datash…
611a669 
…are#1173
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
feat: remove title norm form document tab details ICIJ/datashare#1173
daa07c7
@mvanzalu mvanzalu moved this from Todo to Done in Datashare - Sprint 17 Sep 1, 2023
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
feat: adds Title and Title Normalized in Document details ICIJ/datash…
fcee7de 
…are#1173
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
feat: remove title norm form document tab details ICIJ/datashare#1173
9f26c81
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
feat: activate fielddata for titleNorm ICIJ/datashare#1173
1b6df03
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 1, 2023
@mvanzalu
test: add sort by filename tests ICIJ/datashare#1173
a28a9c9
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: adds title titleNorm in ES document fields #1173
13ed442
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: check if subject and title are empty #1173
91f368a
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: use java Normalizer for titleNorm #1173
fa2f013
mvanzalu added a commit that referenced this issue Sep 1, 2023
@mvanzalu
feat: activate fielddata for titleNorm #1173
b1fba78
mvanzalu added a commit that referenced this issue Sep 4, 2023
@mvanzalu
fix: use title and subject for email/tweet #1173
8f043a6
@mvanzalu mvanzalu mentioned this issue Sep 4, 2023
Merged
mvanzalu added a commit that referenced this issue Sep 4, 2023
@mvanzalu
fix: use title and subject for email/tweet #1173
1483075
mvanzalu added a commit that referenced this issue Sep 4, 2023
@mvanzalu
fix: use title and subject for email/tweet #1173
edcb11e
mvanzalu added a commit that referenced this issue Sep 5, 2023
@mvanzalu
feat: activate fielddata for titleNorm #1173
3a31bb7
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 5, 2023
@mvanzalu
feat: activate fielddata for titleNorm ICIJ/datashare#1173
db41c1e
mvanzalu added a commit to ICIJ/datashare-client that referenced this issue Sep 5, 2023
@mvanzalu
test: add sort by filename tests ICIJ/datashare#1173
ccc62bd
@mvanzalu mvanzalu closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvanzalu mvanzalu

Labels
back
Projects
No open projects
Datashare - Sprint 17
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pirhoo @mvanzalu