Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyarrow as hard dep #523

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Remove pyarrow as hard dep #523

merged 3 commits into from
Dec 2, 2021

Conversation

yannikschaelte
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #523 (0fae14f) into develop (ae48c18) will increase coverage by 0.04%.
The diff coverage is 55.55%.

❗ Current head 0fae14f differs from pull request most recent head e5c4c39. Consider uploading reports for the commit e5c4c39 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #523      +/-   ##
===========================================
+ Coverage    88.59%   88.64%   +0.04%     
===========================================
  Files          125      125              
  Lines         7421     7425       +4     
===========================================
+ Hits          6575     6582       +7     
+ Misses         846      843       -3     
Impacted Files Coverage Δ
pyabc/storage/dataframe_bytes_storage.py 85.13% <55.55%> (+5.13%) ⬆️
pyabc/inference_util.py 95.89% <0.00%> (-0.69%) ⬇️
pyabc/weighted_statistics.py 92.06% <0.00%> (ø)
pyabc/sampler/mapping.py 97.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae48c18...e5c4c39. Read the comment docs.

@yannikschaelte yannikschaelte merged commit 53c9165 into develop Dec 2, 2021
@yannikschaelte yannikschaelte deleted the fixes_ys branch December 2, 2021 23:55
@yannikschaelte yannikschaelte self-assigned this Dec 3, 2021
EmadAlamoudi pushed a commit that referenced this pull request Jun 30, 2022
* Remove pyarrow as hard dep

* return something

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants