Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional pickling for multicore samplers #320

Merged
merged 15 commits into from
Jun 15, 2020

Conversation

yannikschaelte
Copy link
Member

@yannikschaelte yannikschaelte commented Jun 15, 2020

This should enable using the multicore samplers on systems where multiprocessing pickles arguments (e.g. macos with python3.8).

Adds a basic pipeline test on MacOS systems, however the general test suite does not run (multiple errors with redis and processes ...). Could be extended, but should be fine for the moment, considering MacOS support tentative.

Fixes #286.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #320 into develop will decrease coverage by 0.02%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #320      +/-   ##
===========================================
- Coverage    83.39%   83.36%   -0.03%     
===========================================
  Files           87       87              
  Lines         4949     4972      +23     
===========================================
+ Hits          4127     4145      +18     
- Misses         822      827       +5     
Impacted Files Coverage Δ
pyabc/platform_factory.py 90.90% <83.33%> (-9.10%) ⬇️
pyabc/sampler/multicore.py 98.18% <100.00%> (+0.22%) ⬆️
pyabc/sampler/multicore_evaluation_parallel.py 100.00% <100.00%> (ø)
pyabc/sampler/multicorebase.py 97.56% <100.00%> (+0.41%) ⬆️
pyabc/weighted_statistics.py 80.70% <0.00%> (-10.53%) ⬇️
pyabc/smc.py 96.16% <0.00%> (+0.29%) ⬆️
pyabc/sampler/redis_eps/cli.py 80.85% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea99020...753b2fa. Read the comment docs.

@yannikschaelte yannikschaelte merged commit 83e8bfb into develop Jun 15, 2020
@yannikschaelte yannikschaelte deleted the fix_pickling branch June 15, 2020 20:50
@yannikschaelte yannikschaelte mentioned this pull request Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants