Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.0 #271

Merged
merged 15 commits into from
Feb 20, 2020
Merged

Release 0.10.0 #271

merged 15 commits into from
Feb 20, 2020

Conversation

yannikschaelte
Copy link
Member

@yannikschaelte yannikschaelte commented Feb 18, 2020

yannikschaelte and others added 4 commits February 12, 2020 14:55
* closing #109

* fixing flake8

* change the message

* fixing

* finish logging of core numbers

* tidy up

Co-authored-by: Yannik Schälte <[email protected]>
* fix two regularly stochastically failing tests

* add explanation

* add scaled pdf norm

* fix wrong branch

* fix errors

* fixup
* add scaled pdf norm

* add tests for scaled pdf norm

* update __init__s
@yannikschaelte yannikschaelte self-assigned this Feb 18, 2020
* add first petab import draft

* allow arbitrary prior distributions

* extend gitignore, flake8 excludes

* parameters: subclass dict directly instead of UserDict (possible in python 3, and to ensure compatibility with python 3.8

* add StochasticKernel to __init__

* add extras_require petab-amici

* tidy up petab import; fix namings

* add petab, amici to travis reqs

* test

* install amici dependencies

* run petab notebook

* adapt nb

* add ScaledPDFNorm

* create base PEtabImporter

* cont

* tidy up petab notebook

* set "zero transition density" info to debug level

* ignore amici_models

* add tests for petab

* fixup

* fix minor errors

* fix .travis.yml

* update version and releasenotes for 0.10.0

* rerun petab notebook

* add petab notebook to docs

* address reviewer comments

* fix typo

* tidy up .gitignore

* tidy up
@yannikschaelte yannikschaelte requested review from EmadAlamoudi, elbaraim and JanHasenauer and removed request for JanHasenauer February 18, 2020 11:09
@yannikschaelte yannikschaelte added this to the StochasticAcceptor milestone Feb 18, 2020
@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d9f56e3). Click here to learn what that means.
The diff coverage is 78.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #271   +/-   ##
=========================================
  Coverage          ?   83.48%           
=========================================
  Files             ?       88           
  Lines             ?     4863           
  Branches          ?        0           
=========================================
  Hits              ?     4060           
  Misses            ?      803           
  Partials          ?        0
Impacted Files Coverage Δ
pyabc/acceptor/pdf_norm.py 96.55% <ø> (ø)
pyabc/__init__.py 100% <ø> (ø)
pyabc/storage/history.py 92.96% <100%> (ø)
pyabc/version.py 100% <100%> (ø)
pyabc/transition/model_selection.py 84.37% <100%> (ø)
pyabc/parameters.py 86.84% <100%> (ø)
pyabc/smc.py 95.85% <100%> (ø)
pyabc/transition/transitionmeta.py 100% <100%> (ø)
pyabc/petab/__init__.py 100% <100%> (ø)
pyabc/petab/base.py 67.34% <67.34%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9f56e3...05a44c7. Read the comment docs.

pyabc/acceptor/pdf_norm.py Outdated Show resolved Hide resolved
yannikschaelte and others added 9 commits February 19, 2020 10:05
* use develop branches of amici, petab

* shorten travis times

* fix future warnings

* test

* test

* gridsearchcv: explicit arguments

* test

* test

* test
* find last id of successful run in the database

* address reviewer comments

* address additional reviewer comments

* flake8 fix

Co-authored-by: Yannik Schälte <[email protected]>
* Feature listpopulationsize (#274)

* Init ListPopulation

ListPopulation provides user definded population sizes which are comitted using a list. It's implementation follows the ListEpsilon case. List must have as many entries as populations are to be run.

* Add t argument to adapt_population_size

We will need to configure smc class such that it passes t as an argument to the _adapt_population_size. Therefor all adapt_population_size function have to be given t as well.

* Adapt smc.run to ListPopulation

In order to use ListPopulation we need to break before the _prepare_next_iteration in the end. 
Also pass t to _adapt_population_size

* Update populationstrategy.py

* Pass argumentname for better readability

* Rename class

Class name should contain Size as well

* Added test for ListPopulationSize

Simple test for ListPopulationSize according to the test_ListEpsilon function.

* Add get_config function in ListPopulationSize

Added get_config class according to ListEpsilon.get_config() function

* Reformat code

Added t==t_max other code termination block. Did not add logger info because while loop would not have produced a logger info itself.

* Modify documentation

Changed Population values to PopulationSize values

* Add empty line for doc parsing

* Remove empty line

* Remove assertions

Assertions didnt work.

Co-authored-by: Yannik Schälte <[email protected]>

* fixup

* add docstring

* fix style; back-relocate prepare_next_iteration

* update releasenotes

Co-authored-by: nbungi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants