Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(extension): HTML Report Card Change, View menu, CSS and fonts, Filter addition, and include Hidden #2056

Merged
merged 37 commits into from
Oct 1, 2024

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Sep 24, 2024

  • Extension UI enhancement for HTML reports

This PR is related to the following issue(s):

Testing reference:

Scan several pages of Altoro Mutual and preform the following:

  • review section "2. Create a scan report" in Quick guide
  • review sections in the User guide:
    • "3.4 Create a scan report"
    • "3.5 Create a multi-scan report"
    • "6. Checker reports"

I have conducted the following for this PR:

  • see testing completed in previous PRs feature(extension): HTML Report CSS and Font Fix #2035  #2049
  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins linked an issue Sep 24, 2024 that may be closed by this pull request
2 tasks
@philljenkins philljenkins marked this pull request as ready for review September 26, 2024 13:57
@philljenkins philljenkins requested a review from drjoho September 26, 2024 13:58
@philljenkins philljenkins self-assigned this Sep 26, 2024
Copy link
Contributor

@drjoho drjoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code looks in order. Ran action to test features.

@drjoho
Copy link
Contributor

drjoho commented Sep 26, 2024

@ErickRenteria - ready for test.

@drjoho
Copy link
Contributor

drjoho commented Oct 1, 2024

I ran through all changes and made videos to show them in action for both report and the help:
https://ibm.ent.box.com/file/1661566447030
https://ibm.ent.box.com/file/1661617391625
All is fine and ready to go.

@sct-will
Copy link
Contributor

sct-will commented Oct 1, 2024

This has been reviewed.

Validation of reports: https://ibm.box.com/s/o2uo6x9b8krij566s7menzuedldsrkvy

Validation of help: https://ibm.box.com/s/vscx9oa5gjnjylroxmuw4iujkprfnmrv

@sct-will sct-will merged commit 91da1b0 into master Oct 1, 2024
17 checks passed
@sct-will
Copy link
Contributor

sct-will commented Oct 1, 2024

Merged. FYI @tombrunet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants