fixrule(aria_accessiblename_exists): Was firing for img with alt text, which is handled by img_alt_valid
#1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philljenkins
approved these changes
Aug 12, 2024
philljenkins
changed the title
aria_accessiblename_exists): Was firing for img with alt text, which is handled by img_alt_valid #1980Fix build error
1 task
tombrunet
changed the title
aria_accessiblename_exists): Was firing for img with alt text, which is handled by img_alt_valid #1980Fix build erroraria_accessiblename_exists): Was firing for img with alt text, which is handled by img_alt_valid
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Build was failing due to cypress using remote archive, which didn't detect scenario of recommendation failing when img had alt text
Testing reference:
I have conducted the following for this PR: