Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrules(meta_redirect_optional, aria_parent_required, aria_child_valid): Map to WCAG and ACT rules to improve consistency #1962

Merged
merged 6 commits into from
Aug 1, 2024
Merged

fixrules(meta_redirect_optional, aria_parent_required, aria_child_valid): Map to WCAG and ACT rules to improve consistency #1962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8736ea8
1955 remove mapping to AAA ACT rule
philljenkins Jul 26, 2024
4b3b5e5
1956 map to 1.3.1 not 4.1.2
philljenkins Jul 26, 2024
119cbc4
1957 map to WCAG 1.3.1 not 4.1.2
philljenkins Jul 26, 2024
af41fe6
Code formatting and comments
philljenkins Jul 26, 2024
d89e4e6
Merge branch 'master' into phill-ACT-mapping
shunguoy Jul 29, 2024
f279c3b
Merge branch 'master' into phill-ACT-mapping
philljenkins Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion accessibility-checker-engine/help-v4/en-US/aria_child_valid.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ <h3 id="ruleMessage"></h3>

### About this requirement

* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [IBM 1.3.1 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#1_3_1)
* [ARIA practices guide](https://www.w3.org/WAI/ARIA/apg/)
* [ARIA specification - Required Owned Elements](https://www.w3.org/TR/wai-aria-1.2/#mustContain)

Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/help-v4/en-US/aria_parent_required.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ <h3 id="ruleMessage"></h3>

### About this requirement

* [IBM 4.1.2 Name, Role, Value](https://www.ibm.com/able/requirements/requirements/#4_1_2)
* [IBM 1.3.1 Info and Relationships](https://www.ibm.com/able/requirements/requirements/#1_3_1)
* [ARIA - Required Context Role](https://www.w3.org/TR/wai-aria/#scope)

### Who does this affect?
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/aria_child_valid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export let aria_child_valid: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["4.1.2"],
"num": ["1.3.1"],
"level": eRulePolicy.RECOMMENDATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/rules/aria_parent_required.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export let aria_parent_required: Rule = {
},
rulesets: [{
"id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
"num": ["4.1.2"],
"num": ["1.3.1"],
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_ONE
}],
Expand Down
15 changes: 7 additions & 8 deletions accessibility-checker-engine/src/v4/rules/meta_redirect_optional.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,14 @@ export let meta_redirect_optional: Rule = {
"level": eRulePolicy.VIOLATION,
"toolkitLevel": eToolkitLevel.LEVEL_THREE
}],
act: [ "bisz58",
{
"bc659a" : {
"pass": "pass",
"fail": "fail",
"fail_longrefresh": "pass"
}
// Removed ACT bisz58 AAA
act: [{
"bc659a" : {
"pass": "pass",
"fail": "fail",
"fail_longrefresh": "pass"
}
],
}],
run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
const ruleContext = context["dom"].node as Element;
// JCH - NO OUT OF SCOPE hidden in context
Expand Down
Loading