-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine): Update the engine to fix ARIA definition and other issues #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunguoy
changed the title
fix(engine): Update the engine to fix Aria definition and other issues
fix(engine): Update the engine to fix ARIA definition and other issues
Jun 19, 2024
tombrunet
previously approved these changes
Jun 21, 2024
tombrunet
approved these changes
Jun 27, 2024
ErickRenteria
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(engine): Update the engine to fix Aria definition and other issues
This PR is related to the following issue(s):
Fixes #842
Fixes #1910
Fixes #1844
Testing reference:
For #842: test/v2/checker/accessibility/rules/aria_attribute_required_ruleunit/input_checkbox.html
Before the fix: two violation messages:
An element with ARIA role 'switch' does not have the required ARIA attribute(s): 'aria-checked'
The ARIA attributes "aria-checked" are not valid for the element with ARIA role "switch"
After the fix: only one violation message:
The ARIA attributes "aria-checked" are not valid for the element with ARIA role "switch"
For #1910: test/v2/checker/accessibility/rules/input_label_exists_ruleunit/input-datetime.html
Before the fix: Violation message: The value "datetime2" of the 'for' attribute is not the 'id' of a valid element
After the fix: Violation message: The value "datetime1" of the 'for' attribute is not the 'id' of a valid element
For #1844: test/v2/checker/accessibility/rules/aria_attribute_conflict_ruleunit/aria-hidden.html
After the fix: a new violation message: The ARIA attribute "aria-hidden" is in conflict with the corresponding HTML attribute "hidden"
I have conducted the following for this PR: