Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): Update the engine to fix ARIA definition and other issues #1936

Merged
merged 14 commits into from
Jun 27, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jun 18, 2024

fix(engine): Update the engine to fix Aria definition and other issues

This PR is related to the following issue(s):

Fixes #842
Fixes #1910
Fixes #1844

Testing reference:

For #842: test/v2/checker/accessibility/rules/aria_attribute_required_ruleunit/input_checkbox.html
Before the fix: two violation messages:
An element with ARIA role 'switch' does not have the required ARIA attribute(s): 'aria-checked'
The ARIA attributes "aria-checked" are not valid for the element with ARIA role "switch"
After the fix: only one violation message:
The ARIA attributes "aria-checked" are not valid for the element with ARIA role "switch"

For #1910: test/v2/checker/accessibility/rules/input_label_exists_ruleunit/input-datetime.html
Before the fix: Violation message: The value "datetime2" of the 'for' attribute is not the 'id' of a valid element
After the fix: Violation message: The value "datetime1" of the 'for' attribute is not the 'id' of a valid element

For #1844: test/v2/checker/accessibility/rules/aria_attribute_conflict_ruleunit/aria-hidden.html
After the fix: a new violation message: The ARIA attribute "aria-hidden" is in conflict with the corresponding HTML attribute "hidden"

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fix(engine): Update the engine to fix Aria definition and other issues fix(engine): Update the engine to fix ARIA definition and other issues Jun 19, 2024
@shunguoy shunguoy requested a review from tombrunet June 19, 2024 19:37
@shunguoy shunguoy marked this pull request as ready for review June 19, 2024 19:37
tombrunet
tombrunet previously approved these changes Jun 21, 2024
@ErickRenteria
Copy link
Contributor

842 Validated:
Screenshot 2024-06-26 at 8 20 48 PM

1910 Validated
Screenshot 2024-06-26 at 8 23 03 PM

1844 Validate with a small spell correction
Screenshot 2024-06-26 at 8 26 46 PM

@ErickRenteria ErickRenteria merged commit a19ccb8 into master Jun 27, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-842 branch August 2, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants