Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(widget_tabbable_single): Radio inputs in the same group should have only one tab stop #1913

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented May 28, 2024

  • Rule bug: widget_tabbable_single

This PR is related to the following issue(s):

Fixes: #1649

Testing reference:

test case: test/v2/checker/accessibility/rules/widget_tabbable_single_ruleunit/radiogroup_native.html
Before fix: Recommendation: "Component with "radiogroup" role has more than one tabbable element"
After the fix: the recommendation should be gone.

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy requested a review from tombrunet May 28, 2024 21:35
@shunguoy shunguoy marked this pull request as ready for review May 28, 2024 21:35
@shunguoy shunguoy changed the title fixrule(widget_tabbable_single): Radio inputs with the same name natively are only one tab stop fixrule(widget_tabbable_single): Radio inputs in the same group should have only one tab stop May 28, 2024
@ErickRenteria
Copy link
Contributor

validated
Screenshot 2024-06-02 at 11 12 08 PM

@ErickRenteria ErickRenteria added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit dc4aed3 Jun 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit: widget_tabbable_single - can we tighten scope?
3 participants